mojo/shell/package_manager/package_manager_impl.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/package_manager/package_manager_impl.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/package_manager/package_manager_impl.cc

diff --git a/mojo/shell/package_manager/package_manager_impl.cc b/mojo/shell/package_manager/package_manager_impl.cc

index 9b95c3edee4326bbb10df5975d86e39350c074e9..54213d55c3bf34c26f05abf0efa83cb33f1efaa6 100644

--- a/mojo/shell/package_manager/package_manager_impl.cc

+++ b/mojo/shell/package_manager/package_manager_impl.cc

@@ -72,7 +72,7 @@ void PackageManagerImpl::SetApplicationManager(ApplicationManager* manager) {

void PackageManagerImpl::FetchRequest(

URLRequestPtr request,

const Fetcher::FetchCallback& loader_callback) {

- GURL url(request->url);

+ GURL url(request->url.get());

if (url.SchemeIs(AboutFetcher::kAboutScheme)) {

AboutFetcher::Start(url, loader_callback);

return;