Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/resource_request_policy.cc
diff --git a/chrome/renderer/extensions/resource_request_policy.cc b/chrome/renderer/extensions/resource_request_policy.cc
index 85a74232cf96fdd89b2de5f0745f9ac958b91e09..a874c3168130de220e1a43a7f64d28cdbcf40d8b 100644
--- a/chrome/renderer/extensions/resource_request_policy.cc
+++ b/chrome/renderer/extensions/resource_request_policy.cc
@@ -8,6 +8,7 @@
#include "base/strings/stringprintf.h"
#include "chrome/common/extensions/chrome_manifest_url_handlers.h"
#include "chrome/common/url_constants.h"
+#include "content/public/child/url_conversion.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest_constants.h"
@@ -74,7 +75,8 @@ bool ResourceRequestPolicy::CanRequestResource(
// The page_origin may be GURL("null") for unique origins like data URLs,
// but this is ok for the checks below. We only care if it matches the
// current extension or has a devtools scheme.
- GURL page_origin = GURL(frame->top()->securityOrigin().toString());
+ GURL page_origin =
+ content::WebStringToGURL(frame->top()->securityOrigin().toString());
// Exceptions are:
// - empty origin (needed for some edge cases when we have empty origins)

Powered by Google App Engine
This is Rietveld 408576698