Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: chrome/renderer/extensions/media_galleries_custom_bindings.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/media_galleries_custom_bindings.cc
diff --git a/chrome/renderer/extensions/media_galleries_custom_bindings.cc b/chrome/renderer/extensions/media_galleries_custom_bindings.cc
index 16d0b4aee15381e42d9aa0781b0a1a56af784779..445d37a4d7203e8bd7a4c34b7ec63f3dd5b8341b 100644
--- a/chrome/renderer/extensions/media_galleries_custom_bindings.cc
+++ b/chrome/renderer/extensions/media_galleries_custom_bindings.cc
@@ -6,6 +6,7 @@
#include <string>
+#include "content/public/child/url_conversion.h"
#include "extensions/renderer/script_context.h"
#include "storage/common/fileapi/file_system_util.h"
#include "third_party/WebKit/public/web/WebDOMFileSystem.h"
@@ -36,7 +37,8 @@ void MediaGalleriesCustomBindings::GetMediaFileSystemObject(
blink::WebLocalFrame* webframe =
blink::WebLocalFrame::frameForCurrentContext();
- const GURL origin = GURL(webframe->document().securityOrigin().toString());
+ const GURL origin = content::WebStringToGURL(
+ webframe->document().securityOrigin().toString());
std::string fs_name =
storage::GetFileSystemName(origin, storage::kFileSystemTypeExternal);
fs_name.append("_");

Powered by Google App Engine
This is Rietveld 408576698