Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1567983002: Add guards to GrTextureProvider (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gpudeviceguards
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : move function to cpp so it can be guarded #

Patch Set 3 : mutable so mac doesn't complain #

Patch Set 4 : try 2 #

Patch Set 5 : got it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M include/gpu/GrDrawContext.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTextureProvider.h View 1 2 3 4 4 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 2 3 4 7 chunks +34 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
joshualitt
There are a couple of inlined functions in the header, I can add guards there ...
4 years, 11 months ago (2016-01-07 19:02:32 UTC) #3
robertphillips
https://codereview.chromium.org/1567983002/diff/1/include/gpu/GrTextureProvider.h File include/gpu/GrTextureProvider.h (right): https://codereview.chromium.org/1567983002/diff/1/include/gpu/GrTextureProvider.h#newcode193 include/gpu/GrTextureProvider.h:193: GrGpu* fGpu; // Guard for single-threaded access. Owned by ...
4 years, 11 months ago (2016-01-07 19:07:02 UTC) #4
joshualitt
On 2016/01/07 19:07:02, robertphillips wrote: > https://codereview.chromium.org/1567983002/diff/1/include/gpu/GrTextureProvider.h > File include/gpu/GrTextureProvider.h (right): > > https://codereview.chromium.org/1567983002/diff/1/include/gpu/GrTextureProvider.h#newcode193 > ...
4 years, 11 months ago (2016-01-07 19:18:09 UTC) #5
robertphillips
lgtm
4 years, 11 months ago (2016-01-07 19:19:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567983002/20001
4 years, 11 months ago (2016-01-07 19:38:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/7513) skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, ...
4 years, 11 months ago (2016-01-07 19:39:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567983002/40001
4 years, 11 months ago (2016-01-07 19:57:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5118)
4 years, 11 months ago (2016-01-07 19:58:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567983002/80001
4 years, 11 months ago (2016-01-07 20:35:00 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/b30dd1db1d914b85a691b4724713ba1b0f16cd6c
4 years, 11 months ago (2016-01-07 20:52:08 UTC) #23
joshualitt
4 years, 11 months ago (2016-01-07 21:17:30 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1565313003/ by joshualitt@google.com.

The reason for reverting is: breaking asan bot.

Powered by Google App Engine
This is Rietveld 408576698