Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1563703004: Make a single GrSingleOwner in GrContext (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M include/gpu/GrContext.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/private/GrSingleOwner.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
joshualitt
I'm open to alternative ideas, this one seems not so bad.
4 years, 11 months ago (2016-01-06 19:06:54 UTC) #3
joshualitt
On 2016/01/06 19:06:54, joshualitt wrote: > I'm open to alternative ideas, this one seems not ...
4 years, 11 months ago (2016-01-07 16:04:13 UTC) #4
robertphillips
lgtm + 2 documentation suggestions https://codereview.chromium.org/1563703004/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/1563703004/diff/1/include/gpu/GrContext.h#newcode394 include/gpu/GrContext.h:394: // In debug builds ...
4 years, 11 months ago (2016-01-07 16:44:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563703004/20001
4 years, 11 months ago (2016-01-07 19:00:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5108)
4 years, 11 months ago (2016-01-07 19:01:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563703004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563703004/40001
4 years, 11 months ago (2016-01-07 19:15:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/f9bc796e0dbd31674c22b34761913ee6e8fdd66a
4 years, 11 months ago (2016-01-07 19:32:42 UTC) #16
joshualitt
4 years, 11 months ago (2016-01-07 21:17:56 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1565303003/ by joshualitt@google.com.

The reason for reverting is: breaking asan .

Powered by Google App Engine
This is Rietveld 408576698