Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/a64/lithium-codegen-a64.cc

Issue 156733005: A64: Add support for loading cp from deferred if it's stored in new space (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/lithium-codegen-a64.cc
diff --git a/src/a64/lithium-codegen-a64.cc b/src/a64/lithium-codegen-a64.cc
index 64da578e5ccf5667e7f44cf9063dd64781341319..da03ccc214700a949048b590d342a434f84521c2 100644
--- a/src/a64/lithium-codegen-a64.cc
+++ b/src/a64/lithium-codegen-a64.cc
@@ -520,9 +520,8 @@ void LCodeGen::LoadContextFromDeferred(LOperand* context) {
} else if (context->IsConstantOperand()) {
HConstant* constant =
chunk_->LookupConstant(LConstantOperand::cast(context));
- // TODO(all): on ARM this move can handle object in new space, not in A64.
- // Check if this can be a problem.
- __ Mov(cp, Operand(Handle<Object>::cast(constant->handle(isolate()))));
+ __ LoadHeapObject(cp,
ulan 2014/02/11 10:49:04 ARM uses "Move(cp.." here.
jochen (gone - plz use gerrit) 2014/02/11 10:50:31 Yes, but A64 doesn't have such a fancy move. Howev
+ Handle<HeapObject>::cast(constant->handle(isolate())));
} else {
UNREACHABLE();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698