Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 156733005: A64: Add support for loading cp from deferred if it's stored in new space (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Add support for loading cp from deferred if it's stored in new space BUG=none R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=n TEST=mjsunit/regress/binop-in-effect-context-deop Committed: https://code.google.com/p/v8/source/detail?r=19269

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +2 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-11 10:46:51 UTC) #1
ulan
https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc#newcode523 src/a64/lithium-codegen-a64.cc:523: __ LoadHeapObject(cp, ARM uses "Move(cp.." here.
6 years, 10 months ago (2014-02-11 10:49:04 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc#newcode523 src/a64/lithium-codegen-a64.cc:523: __ LoadHeapObject(cp, On 2014/02/11 10:49:04, ulan wrote: > ARM ...
6 years, 10 months ago (2014-02-11 10:50:31 UTC) #3
jochen (gone - plz use gerrit)
On 2014/02/11 10:50:31, jochen wrote: > https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc > File src/a64/lithium-codegen-a64.cc (right): > > https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc#newcode523 > ...
6 years, 10 months ago (2014-02-11 10:51:16 UTC) #4
jochen (gone - plz use gerrit)
On 2014/02/11 10:51:16, jochen wrote: > On 2014/02/11 10:50:31, jochen wrote: > > > https://codereview.chromium.org/156733005/diff/1/src/a64/lithium-codegen-a64.cc ...
6 years, 10 months ago (2014-02-11 10:51:39 UTC) #5
ulan
lgtm
6 years, 10 months ago (2014-02-11 10:58:19 UTC) #6
Rodolph Perfetta (ARM)
lgtm
6 years, 10 months ago (2014-02-11 10:58:47 UTC) #7
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-11 10:58:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r19269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698