Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 156733005: A64: Add support for loading cp from deferred if it's stored in new space (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 513
514 514
515 void LCodeGen::LoadContextFromDeferred(LOperand* context) { 515 void LCodeGen::LoadContextFromDeferred(LOperand* context) {
516 if (context->IsRegister()) { 516 if (context->IsRegister()) {
517 __ Mov(cp, ToRegister(context)); 517 __ Mov(cp, ToRegister(context));
518 } else if (context->IsStackSlot()) { 518 } else if (context->IsStackSlot()) {
519 __ Ldr(cp, ToMemOperand(context)); 519 __ Ldr(cp, ToMemOperand(context));
520 } else if (context->IsConstantOperand()) { 520 } else if (context->IsConstantOperand()) {
521 HConstant* constant = 521 HConstant* constant =
522 chunk_->LookupConstant(LConstantOperand::cast(context)); 522 chunk_->LookupConstant(LConstantOperand::cast(context));
523 // TODO(all): on ARM this move can handle object in new space, not in A64. 523 __ LoadHeapObject(cp,
ulan 2014/02/11 10:49:04 ARM uses "Move(cp.." here.
jochen (gone - plz use gerrit) 2014/02/11 10:50:31 Yes, but A64 doesn't have such a fancy move. Howev
524 // Check if this can be a problem. 524 Handle<HeapObject>::cast(constant->handle(isolate())));
525 __ Mov(cp, Operand(Handle<Object>::cast(constant->handle(isolate()))));
526 } else { 525 } else {
527 UNREACHABLE(); 526 UNREACHABLE();
528 } 527 }
529 } 528 }
530 529
531 530
532 void LCodeGen::CallRuntimeFromDeferred(Runtime::FunctionId id, 531 void LCodeGen::CallRuntimeFromDeferred(Runtime::FunctionId id,
533 int argc, 532 int argc,
534 LInstruction* instr, 533 LInstruction* instr,
535 LOperand* context) { 534 LOperand* context) {
(...skipping 5159 matching lines...) Expand 10 before | Expand all | Expand 10 after
5695 __ Bind(&out_of_object); 5694 __ Bind(&out_of_object);
5696 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5695 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5697 // Index is equal to negated out of object property index plus 1. 5696 // Index is equal to negated out of object property index plus 1.
5698 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5697 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5699 __ Ldr(result, FieldMemOperand(result, 5698 __ Ldr(result, FieldMemOperand(result,
5700 FixedArray::kHeaderSize - kPointerSize)); 5699 FixedArray::kHeaderSize - kPointerSize));
5701 __ Bind(&done); 5700 __ Bind(&done);
5702 } 5701 }
5703 5702
5704 } } // namespace v8::internal 5703 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698