Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 156603005: cc: Clean up iterator template to only take 1 parameter. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
ajwong, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Clean up iterator template to only take 1 parameter. LayerIterator takes 4 parameters. One is the FrontToBack ordering but that is now the only option. The other 3 are for the type of layers, render surfaces, and the render surface layer list. The latter two are now already available as typedefs off of Layer and LayerImpl, so we only need Layer/LayerImpl in the template arguments. R=enne@chromium.org, enne BUG=YAK Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251238 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254156

Patch Set 1 #

Patch Set 2 : iteratorcleanup: #

Total comments: 2

Patch Set 3 : iteratorcleanup: removebadchange #

Patch Set 4 : iteratorcleanup: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -252 lines) Patch
M cc/cc.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/debug_rect_history.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M cc/layers/layer_iterator.h View 1 2 3 7 chunks +83 lines, -57 lines 0 comments Download
D cc/layers/layer_iterator.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/layers/render_surface.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/layers/render_surface_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 3 chunks +4 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 2 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 2 3 2 chunks +4 lines, -12 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 3 2 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/quad_culler_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
6 years, 10 months ago (2014-02-11 23:19:47 UTC) #1
enne (OOO)
lgtm https://codereview.chromium.org/156603005/diff/30001/cc/debug/debug_rect_history.cc File cc/debug/debug_rect_history.cc (right): https://codereview.chromium.org/156603005/diff/30001/cc/debug/debug_rect_history.cc#newcode115 cc/debug/debug_rect_history.cc:115: MathUtil::MapClippedRect( This is just a drive-by? Maybe stick ...
6 years, 10 months ago (2014-02-11 23:25:22 UTC) #2
danakj
https://codereview.chromium.org/156603005/diff/30001/cc/debug/debug_rect_history.cc File cc/debug/debug_rect_history.cc (right): https://codereview.chromium.org/156603005/diff/30001/cc/debug/debug_rect_history.cc#newcode115 cc/debug/debug_rect_history.cc:115: MathUtil::MapClippedRect( On 2014/02/11 23:25:22, enne wrote: > This is ...
6 years, 10 months ago (2014-02-11 23:31:00 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-14 00:07:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/156603005/90001
6 years, 10 months ago (2014-02-14 00:08:16 UTC) #5
commit-bot: I haz the power
Change committed as 251238
6 years, 10 months ago (2014-02-14 02:54:15 UTC) #6
danakj
Uploaded a new CL here with an empty struct member added to the LayerIterator class ...
6 years, 9 months ago (2014-02-27 23:13:37 UTC) #7
ajwong
Hey Dana, Can you land this? We'd like to test things out. -Albert On Thu, ...
6 years, 9 months ago (2014-02-28 02:39:25 UTC) #8
danakj
6 years, 9 months ago (2014-02-28 16:44:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r254156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698