net/quic/quic_socket_address_coder.h - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_socket_address_coder.h

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_socket_address_coder.h

diff --git a/net/quic/quic_socket_address_coder.h b/net/quic/quic_socket_address_coder.h

index 0b620ba9a0a26332b0cd8fbb59538d254ca6898a..b58fbcf9afedb19740fac0b58a34aa140189168f 100644

--- a/net/quic/quic_socket_address_coder.h

+++ b/net/quic/quic_socket_address_coder.h

@@ -29,7 +29,7 @@ class NET_EXPORT_PRIVATE QuicSocketAddressCoder {

bool Decode(const char* data, size_t length);

- IPAddressNumber ip() const { return address_.address(); }

+ IPAddressNumber ip() const { return address_.address().bytes(); }

eroman 2016/01/13 23:19:42 I wonder if it is intentional that this code retur

martijnc 2016/01/14 22:48:17 Hmm, not sure why that is. Had a quick look at the

uint16_t port() const { return address_.port(); }

« net/quic/quic_framer_test.cc ('K') | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_socket_address_coder.cc » ('j') | no next file with comments »