net/quic/quic_framer_test.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer_test.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer_test.cc

diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc

index da33b641eb31c00c28229bffdabb9375e1a4f5b7..0fd1efbea3c4e52ec1977dab5841ecc6a60e5f82 100644

--- a/net/quic/quic_framer_test.cc

+++ b/net/quic/quic_framer_test.cc

@@ -2976,9 +2976,10 @@ TEST_P(QuicFramerTest, PublicResetPacketWithClientAddress) {

EXPECT_EQ(kNonceProof, visitor_.public_reset_packet_->nonce_proof);

EXPECT_EQ(kPacketNumber,

visitor_.public_reset_packet_->rejected_packet_number);

- EXPECT_EQ("4.31.198.44",

- IPAddressToString(

- visitor_.public_reset_packet_->client_address.address()));

+ EXPECT_EQ(

+ "4.31.198.44",

+ IPAddressToString(

+ visitor_.public_reset_packet_->client_address.address().bytes()));

eroman 2016/01/13 23:19:42 Can probably do address().ToString() instead of IP

martijnc 2016/01/14 22:48:17 Done.

EXPECT_EQ(443, visitor_.public_reset_packet_->client_address.port());

// Now test framing boundaries.

« net/quic/quic_connection.cc ('K') | « net/quic/quic_crypto_server_stream.cc ('k') | net/quic/quic_socket_address_coder.h » ('j') | net/quic/quic_socket_address_coder.h » ('J')