Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1565223002: Clean up SkXfermode_opts.h (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
lsalzman1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up SkXfermode_opts.h It seems that MSVC + __vectorcall don't play well together, so back ourselves out into a situation where we don't need it. - Inline transfermode functions. This removes the need for SK_VECTORCALL. - Remove 565 destination specializations. Blending into 565 is not speed-critical enough to merit the code bloat. - Removing 565 specializations means a bunch of Sk4px code is now dead. 8888 xfermodes generally speed up a bit from inlining, smoothly ranging from no change down to 0.65x for the fastest functions like Plus or Modulate. 565 xfermodes generally slow down because we're doing 565 -> 8888 and 8888->565 conversion serially[1] and using the stack, smoothly ranging from no change up to 2x slower for the fastest functions like Plus and Modulate. [1] the 565->8888 conversion is actually being autovectorized BUG=skia:4765, skia:4776 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1565223002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/defa0daa6a0f4e97a3527a522ae602c6771a7c80

Patch Set 1 #

Patch Set 2 : names and refactoring #

Patch Set 3 : maybe we dont need to throw away all perf #

Patch Set 4 : typo #

Patch Set 5 : &&&&&& #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -260 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/Sk4px.h View 5 chunks +8 lines, -16 lines 0 comments Download
M src/opts/Sk4px_NEON.h View 1 chunk +0 lines, -71 lines 0 comments Download
M src/opts/Sk4px_SSE2.h View 1 chunk +0 lines, -75 lines 0 comments Download
M src/opts/Sk4px_none.h View 1 chunk +0 lines, -31 lines 0 comments Download
M src/opts/SkXfermode_opts.h View 1 2 3 4 8 chunks +71 lines, -59 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565223002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565223002/60001
4 years, 11 months ago (2016-01-07 20:09:18 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5151)
4 years, 11 months ago (2016-01-07 20:11:48 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565223002/80001
4 years, 11 months ago (2016-01-07 20:17:38 UTC) #17
mtklein_C
4 years, 11 months ago (2016-01-07 20:28:33 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 20:40:53 UTC) #21
lsalzman1
Any reason why the lambdas in the Map calls still need to be there? The ...
4 years, 11 months ago (2016-01-07 21:04:56 UTC) #22
mtklein
On 2016/01/07 21:04:56, lsalzman1 wrote: > Any reason why the lambdas in the Map calls ...
4 years, 11 months ago (2016-01-07 21:06:45 UTC) #23
lsalzman1
lgtm lgtm
4 years, 11 months ago (2016-01-08 19:43:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565223002/80001
4 years, 11 months ago (2016-01-08 19:44:28 UTC) #27
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 19:45:24 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/defa0daa6a0f4e97a3527a522ae602c6771a7c80

Powered by Google App Engine
This is Rietveld 408576698