Fix compilation of breakpad on Linux.

Fix compilation of breakpad on Linux.

Fix some copy/paste errors from commit 41440eaa.

BUG=None
R=thestig@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/ae0fdf6f4335120cae203f76c295824bc5ea432b

[sdefresne, 2016-01-08 08:18:46]

sdefresne@chromium.org changed reviewers:
+ blundell@chromium.org

[sdefresne, 2016-01-08 08:18:46]

Please take a look.

[sdefresne, 2016-01-08 08:30:28]

sdefresne@chromium.org changed reviewers:
+ thestig@chromium.org
- blundell@chromium.org

[sdefresne, 2016-01-08 08:31:00]

Can you have a quick look? It blocking my breakpad roll in Chromium
https://codereview.chromium.org/1567973002.

[Lei Zhang (Do not use), 2016-01-08 08:31:54]

thestig@google.com changed reviewers:
+ thestig@google.com

[Lei Zhang (Do not use), 2016-01-08 08:31:54]

I just uploaded https://codereview.chromium.org/1564193004 :)

[Lei Zhang, 2016-01-08 08:32:54]

Description was changed from

==========
Fix compilation of breakpad on Linux.

Fixes the following compilation error introduced by issue
https://codereview.chromium.org/1562273002:

../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:20:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
        for (const CpuInfoEntry& entry : cpu_info_table) {
                   ^~~~~~~~~~~~
                   CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:42:
error: use of undeclared identifier 'cpu_info_table'
        for (const CpuInfoEntry& entry : cpu_info_table) {
                                         ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:24:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                       ^~~~~~~~~~~~
                       CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:38:
error: no viable conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry'
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                                     ^     ~
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit copy constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry &' for 1st
argument
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit move constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'CpuIdEntry &&' for 1st argument
    const struct CpuIdEntry {

BUG=None
==========

to

==========
Fix compilation of breakpad on Linux.

Fixes the following compilation error introduced by issue
https://codereview.chromium.org/1562273002:

../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:20:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
        for (const CpuInfoEntry& entry : cpu_info_table) {
                   ^~~~~~~~~~~~
                   CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:42:
error: use of undeclared identifier 'cpu_info_table'
        for (const CpuInfoEntry& entry : cpu_info_table) {
                                         ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:24:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                       ^~~~~~~~~~~~
                       CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:38:
error: no viable conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry'
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                                     ^     ~
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit copy constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry &' for 1st
argument
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit move constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'CpuIdEntry &&' for 1st argument
    const struct CpuIdEntry {

BUG=None
==========

[Lei Zhang, 2016-01-08 08:32:54]

thestig@chromium.org changed reviewers:
- thestig@google.com

[Lei Zhang, 2016-01-08 08:33:09]

LGTM, but the commit message is a bit verbose.

[sdefresne, 2016-01-08 08:33:55]

Description was changed from

==========
Fix compilation of breakpad on Linux.

Fixes the following compilation error introduced by issue
https://codereview.chromium.org/1562273002:

../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:20:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
        for (const CpuInfoEntry& entry : cpu_info_table) {
                   ^~~~~~~~~~~~
                   CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1007:42:
error: use of undeclared identifier 'cpu_info_table'
        for (const CpuInfoEntry& entry : cpu_info_table) {
                                         ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:24:
error: unknown type name 'CpuInfoEntry'; did you mean 'CpuIdEntry'?
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                       ^~~~~~~~~~~~
                       CpuIdEntry
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
'CpuIdEntry' declared here
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:1086:38:
error: no viable conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry'
            for (const CpuInfoEntry& entry : cpu_features_entries) {
                                     ^     ~
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit copy constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'const CpuIdEntry &' for 1st
argument
    const struct CpuIdEntry {
                 ^
../../breakpad/src/client/linux/minidump_writer/minidump_writer.cc:897:18: note:
candidate constructor (the implicit move constructor) not viable: no known
conversion from 'const CpuFeaturesEntry' to 'CpuIdEntry &&' for 1st argument
    const struct CpuIdEntry {

BUG=None
==========

to

==========
Fix compilation of breakpad on Linux.

Fix some copy/paste errors from commit 41440eaa.

BUG=None
==========

[sdefresne, 2016-01-08 08:34:33]

Description was changed from

==========
Fix compilation of breakpad on Linux.

Fix some copy/paste errors from commit 41440eaa.

BUG=None
==========

to

==========
Fix compilation of breakpad on Linux.

Fix some copy/paste errors from commit 41440eaa.

BUG=None
R=thestig@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/ae0fdf6f4335120cae203f7...
==========

[sdefresne, 2016-01-08 08:34:34]

Committed patchset #1 (id:1) manually as
ae0fdf6f4335120cae203f76c295824bc5ea432b (presubmit successful).

[sdefresne, 2016-01-08 08:34:43]

On 2016/01/08 at 08:33:09, thestig wrote:
> LGTM, but the commit message is a bit verbose.

Thank you. I reused your commit message.