Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1567973002: Roll breakpad to c051af689cdb08d9cecaa127f3d69eba006d0bc9. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad to c051af689cdb08d9cecaa127f3d69eba006d0bc9. Changes: c051af6 Fix compilation of breakpad on Linux. 8a90f7e Fix deprecatation warning when building for recent SDKs on iOS/OS X. f75cbf8 Use range-based for loops in linux/minidump_writer/minidump_writer.cc. BUG=569158 Committed: https://crrev.com/98e3b7bc81f60f737b02a38776fb36ec0b4b16b4 Cr-Commit-Position: refs/heads/master@{#368305}

Patch Set 1 #

Patch Set 2 : Update roll to c051af689cdb08d9cecaa127f3d69eba006d0bc9 to get Linux compilation fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sdefresne
Please take a look. I chose to remove the -Wno-deprecated-declarations from breakpad/breakpad.gyp so that it ...
4 years, 11 months ago (2016-01-07 18:54:15 UTC) #2
Mark Mentovai
LGTM. The .gyp change is appropriate in this CL.
4 years, 11 months ago (2016-01-07 19:00:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567973002/20001
4 years, 11 months ago (2016-01-08 08:40:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 09:44:58 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 09:45:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98e3b7bc81f60f737b02a38776fb36ec0b4b16b4
Cr-Commit-Position: refs/heads/master@{#368305}

Powered by Google App Engine
This is Rietveld 408576698