Use range-based for loops in linux/minidump_writer/minidump_writer.cc.

Use range-based for loops in linux/minidump_writer/minidump_writer.cc.

Also fix lint errors.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/41440eaa17ec3173365fd0b1e7196500e8c55238

[Lei Zhang, 2016-01-07 01:53:20]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-01-07 01:53:33]

thestig@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-01-07 04:02:12]

LGTM

[Lei Zhang, 2016-01-07 08:53:10]

Description was changed from

==========
Use range-based for loops in linux/minidump_writer/minidump_writer.cc.

Also fix lint errors.
==========

to

==========
Use range-based for loops in linux/minidump_writer/minidump_writer.cc.

Also fix lint errors.

R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/41440eaa17ec3173365fd0b...
==========

[Lei Zhang, 2016-01-07 08:53:12]

Committed patchset #1 (id:20001) manually as
41440eaa17ec3173365fd0b1e7196500e8c55238 (presubmit successful).

[bryan.kroger, 2016-01-07 19:21:08]

On 2016/01/07 08:53:12, Lei Zhang wrote:
> Committed patchset #1 (id:20001) manually as
> 41440eaa17ec3173365fd0b1e7196500e8c55238 (presubmit successful).

This patch seems to be causing an issue:

src/client/linux/minidump_writer/minidump_writer.cc:837:36: error: range-based
'for' loops are not allowed in C++98 mode
         for (CpuInfoEntry& entry : cpu_info_table) {

[Lei Zhang, 2016-01-07 21:28:15]

On 2016/01/07 19:21:08, bryan.kroger wrote:
> On 2016/01/07 08:53:12, Lei Zhang wrote:
> > Committed patchset #1 (id:20001) manually as
> > 41440eaa17ec3173365fd0b1e7196500e8c55238 (presubmit successful).
> 
> This patch seems to be causing an issue:
> 
> src/client/linux/minidump_writer/minidump_writer.cc:837:36: error: range-based
> 'for' loops are not allowed in C++98 mode
>          for (CpuInfoEntry& entry : cpu_info_table) {

Yes, I need to fiddle with autoconf / automake.

[Lei Zhang, 2016-01-08 20:04:21]

On 2016/01/07 21:28:15, Lei Zhang wrote:
> On 2016/01/07 19:21:08, bryan.kroger wrote:
> > On 2016/01/07 08:53:12, Lei Zhang wrote:
> > > Committed patchset #1 (id:20001) manually as
> > > 41440eaa17ec3173365fd0b1e7196500e8c55238 (presubmit successful).
> > 
> > This patch seems to be causing an issue:
> > 
> > src/client/linux/minidump_writer/minidump_writer.cc:837:36: error:
range-based
> > 'for' loops are not allowed in C++98 mode
> >          for (CpuInfoEntry& entry : cpu_info_table) {
> 
> Yes, I need to fiddle with autoconf / automake.

If you sync to commit ae0fdf6 or newer, it should work, assuming ./configure
works.