Don't navigate in WebContentsDelegate::OpenURLFromTab.

Don't navigate in WebContentsDelegate::OpenURLFromTab.

This behavior was originally introduced in
https://codereview.chromium.org/1473423002 to support process
transfers for frame navigations in background pages.  It is no longer
needed for that purpose, as there's now a better fix in place
(shortcutting transfers, https://codereview.chromium.org/1519943002).
This CL reverts this behavior, as it is causing a regression where
dragging links within the Chrome's sign-in popup causes unnecessary
navigations.

BUG=562389
TEST=ExtensionApiTest.(WindowOpenPopupIframe|ContentScriptExtensionProcess|DontInjectContentScriptsInBackgroundPages) still pass with --isolate-extensions or --site-per-process

Committed: https://crrev.com/5a98a052d0d369da615393d3bc26d2db9745f34d
Cr-Commit-Position: refs/heads/master@{#367711}

[alexmos, 2016-01-05 23:41:10]

Description was changed from

==========
Don't navigate in WebContentsDelegate::OpenURLFromTab.

This behavior was originally introduced in r361724 to support process
transfers for frame navigations in background pages.  It is no longer
needed for that purpose, as there's now a better fix in place for
shortcutting transfers in r365443.  This CL reverts this behavior, as
it is causing a regression where dragging links within the Chrome's
sign-in popup causes unnecessary navigations.

BUG=562389
TEST=ExtensionApiTest.(WindowOpenPopupIframe|ContentScriptExtensionProcess|DontInjectContentScriptsInBackgroundPages)
still pass with --isolate-extensions or --site-per-process
==========

to

==========
Don't navigate in WebContentsDelegate::OpenURLFromTab.

This behavior was originally introduced in
https://codereview.chromium.org/1473423002 to support process
transfers for frame navigations in background pages.  It is no longer
needed for that purpose, as there's now a better fix in place
(shortcutting transfers, https://codereview.chromium.org/1519943002).
This CL reverts this behavior, as it is causing a regression where
dragging links within the Chrome's sign-in popup causes unnecessary
navigations.

BUG=562389
TEST=ExtensionApiTest.(WindowOpenPopupIframe|ContentScriptExtensionProcess|DontInjectContentScriptsInBackgroundPages)
still pass with --isolate-extensions or --site-per-process
==========

[alexmos, 2016-01-05 23:43:01]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2016-01-05 23:43:02]

Charlie, can you please take a look?

[Charlie Reis, 2016-01-06 00:03:18]

Thanks for following up on this.  I guess there are delegates that depend on not
navigating via these calls after all.  LGTM.

https://codereview.chromium.org/1563593002/diff/40001/content/shell/browser/s...
File content/shell/browser/shell.cc (right):

https://codereview.chromium.org/1563593002/diff/40001/content/shell/browser/s...
content/shell/browser/shell.cc:292: // Only allows the browser-initiated
navigation to use POST.
This wasn't in the previous Shell::OpenURLFromTab implementation, but I think
it's probably fine to include.

[alexmos, 2016-01-06 00:06:58]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-01-06 00:08:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1563593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1563593002/40001

[commit-bot: I haz the power, 2016-01-06 00:15:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-06 00:16:02]

Description was changed from

==========
Don't navigate in WebContentsDelegate::OpenURLFromTab.

This behavior was originally introduced in
https://codereview.chromium.org/1473423002 to support process
transfers for frame navigations in background pages.  It is no longer
needed for that purpose, as there's now a better fix in place
(shortcutting transfers, https://codereview.chromium.org/1519943002).
This CL reverts this behavior, as it is causing a regression where
dragging links within the Chrome's sign-in popup causes unnecessary
navigations.

BUG=562389
TEST=ExtensionApiTest.(WindowOpenPopupIframe|ContentScriptExtensionProcess|DontInjectContentScriptsInBackgroundPages)
still pass with --isolate-extensions or --site-per-process
==========

to

==========
Don't navigate in WebContentsDelegate::OpenURLFromTab.

This behavior was originally introduced in
https://codereview.chromium.org/1473423002 to support process
transfers for frame navigations in background pages.  It is no longer
needed for that purpose, as there's now a better fix in place
(shortcutting transfers, https://codereview.chromium.org/1519943002).
This CL reverts this behavior, as it is causing a regression where
dragging links within the Chrome's sign-in popup causes unnecessary
navigations.

BUG=562389
TEST=ExtensionApiTest.(WindowOpenPopupIframe|ContentScriptExtensionProcess|DontInjectContentScriptsInBackgroundPages)
still pass with --isolate-extensions or --site-per-process

Committed: https://crrev.com/5a98a052d0d369da615393d3bc26d2db9745f34d
Cr-Commit-Position: refs/heads/master@{#367711}
==========

[commit-bot: I haz the power, 2016-01-06 00:16:04]

Patchset 3 (id:??) landed as
https://crrev.com/5a98a052d0d369da615393d3bc26d2db9745f34d
Cr-Commit-Position: refs/heads/master@{#367711}