Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 1563593002: Don't navigate in WebContentsDelegate::OpenURLFromTab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/browser/shell.h » ('j') | content/shell/browser/shell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_delegate.cc
diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
index e247f5b0ae2c8750c59f8d4734144e2d7db913db..0a1d3f13480a1a8270755bf9f3d5cb78c3fabafa 100644
--- a/content/public/browser/web_contents_delegate.cc
+++ b/content/public/browser/web_contents_delegate.cc
@@ -23,33 +23,7 @@ WebContentsDelegate::WebContentsDelegate() {
WebContents* WebContentsDelegate::OpenURLFromTab(WebContents* source,
const OpenURLParams& params) {
- // This default implementation only handles CURRENT_TAB.
- if (params.disposition != CURRENT_TAB)
- return nullptr;
-
- NavigationController::LoadURLParams load_url_params(params.url);
- load_url_params.source_site_instance = params.source_site_instance;
- load_url_params.transition_type = params.transition;
- load_url_params.frame_tree_node_id = params.frame_tree_node_id;
- load_url_params.referrer = params.referrer;
- load_url_params.redirect_chain = params.redirect_chain;
- load_url_params.extra_headers = params.extra_headers;
- load_url_params.is_renderer_initiated = params.is_renderer_initiated;
- load_url_params.transferred_global_request_id =
- params.transferred_global_request_id;
- load_url_params.should_replace_current_entry =
- params.should_replace_current_entry;
-
- // Only allows the browser-initiated navigation to use POST.
- if (params.uses_post && !params.is_renderer_initiated) {
- load_url_params.load_type =
- NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST;
- load_url_params.browser_initiated_post_data =
- params.browser_initiated_post_data;
- }
-
- source->GetController().LoadURLWithParams(load_url_params);
- return source;
+ return nullptr;
}
bool WebContentsDelegate::ShouldTransferNavigation() {
« no previous file with comments | « no previous file | content/shell/browser/shell.h » ('j') | content/shell/browser/shell.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698