Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: content/shell/browser/shell.cc

Issue 1563593002: Don't navigate in WebContentsDelegate::OpenURLFromTab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell.cc
diff --git a/content/shell/browser/shell.cc b/content/shell/browser/shell.cc
index 81c9cad0b32bd3d91b7e15e28506a990da3b9cc1..409f0d414826329852b675afaa8a9fba3c1f9d81 100644
--- a/content/shell/browser/shell.cc
+++ b/content/shell/browser/shell.cc
@@ -270,6 +270,37 @@ gfx::NativeView Shell::GetContentView() {
return web_contents_->GetNativeView();
}
+WebContents* Shell::OpenURLFromTab(WebContents* source,
+ const OpenURLParams& params) {
+ // This implementation only handles CURRENT_TAB.
+ if (params.disposition != CURRENT_TAB)
+ return nullptr;
+
+ NavigationController::LoadURLParams load_url_params(params.url);
+ load_url_params.source_site_instance = params.source_site_instance;
+ load_url_params.transition_type = params.transition;
+ load_url_params.frame_tree_node_id = params.frame_tree_node_id;
+ load_url_params.referrer = params.referrer;
+ load_url_params.redirect_chain = params.redirect_chain;
+ load_url_params.extra_headers = params.extra_headers;
+ load_url_params.is_renderer_initiated = params.is_renderer_initiated;
+ load_url_params.transferred_global_request_id =
+ params.transferred_global_request_id;
+ load_url_params.should_replace_current_entry =
+ params.should_replace_current_entry;
+
+ // Only allows the browser-initiated navigation to use POST.
Charlie Reis 2016/01/06 00:03:18 This wasn't in the previous Shell::OpenURLFromTab
+ if (params.uses_post && !params.is_renderer_initiated) {
+ load_url_params.load_type =
+ NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST;
+ load_url_params.browser_initiated_post_data =
+ params.browser_initiated_post_data;
+ }
+
+ source->GetController().LoadURLWithParams(load_url_params);
+ return source;
+}
+
void Shell::LoadingStateChanged(WebContents* source,
bool to_different_document) {
UpdateNavigationControls(to_different_document);
« no previous file with comments | « content/shell/browser/shell.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698