Issue 1395673002: mac: 10.11 SDK compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395673002: mac: 10.11 SDK compatibility (Closed)

Created:
5 years, 2 months ago by Mark Mentovai

Modified:
5 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

mac: 10.11 SDK compatibility This doesn’t really provide compatibility, it just ignores the deprecation warning for +[NSURLConnection sendSynchronousRequest:returningResponse:error:]. The suggested replacement, NSURLSession, was new in 10.9, and this code needs to run on 10.6, so it’s not usable here, at least not without a runtime check. BUG=crashpad:65 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9fdb70738b351281fade7156cdac6db7bcbdabbc

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	util/net/http_transport_mac.mm	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 2 months ago (2015-10-07 20:16:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9fdb70738b351281fade7156cdac6db7bcbdabbc (presubmit successful).