Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid. [-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error: 'sendSynchronousRequest:returningResponse:error:' is deprecated: first deprecated in iOS 9.0 - Use [NSURLSession dataTaskWithRequest:completionHandler:] (see NSURLSession.h [-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error: 'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 - Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/7cc0d8562bf8b20b88cc941ba72593cb7230ecf6

[sdefresne, 2016-01-07 15:51:18]

Description was changed from

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=675
==========

to

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=breakpad:675
==========

[sdefresne, 2016-01-07 15:53:14]

Description was changed from

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=breakpad:675
==========

to

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
==========

[sdefresne, 2016-01-07 15:53:42]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org

[sdefresne, 2016-01-07 15:53:42]

Please take a look (let's hope no-one else already did address those compilation
errors this time).

[Mark Mentovai, 2016-01-07 17:19:16]

We dealt with the NSURLRequest thing in Crashpad already
(https://codereview.chromium.org/1395673002) but not yet in Breakpad.

https://codereview.chromium.org/1563223004/diff/1/src/client/mac/handler/mini...
File src/client/mac/handler/minidump_generator.cc (right):

https://codereview.chromium.org/1563223004/diff/1/src/client/mac/handler/mini...
src/client/mac/handler/minidump_generator.cc:158:
static_cast<CFDictionaryRef>(CFPropertyListCreateWithData(
OS X 10.6 and iOS 4. OK.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
File src/common/mac/HTTPMultipartUpload.m (right):

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:34: // deprecated with iOS 9.0 / OS X 10.11
SDKs, this function re-implement it
re-implements

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:37: static NSString
*EscapeStringByAddingPercent(NSString *key) {
Naming like PercentEncodeNSString()?

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:38: #if
(defined(__IPHONE_OS_VERSION_MIN_REQUIRED) &&  \
#include <Availability.h> for this.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:40: (defined(MAC_OS_X_VERSION_MIN_REQUIRED)
&&     \
#include <AvailabilityMacros.h> for this.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:41: MAC_OS_X_VERSION_MIN_REQUIRED >= 1011)
MAC_OS_X_VERSION_10_11 instead of 1011. Because 1011 is wrong, the actual value
is 101100. But you need to check that MAC_OS_X_VERSION_10_11 is actually
defined, because it isn’t defined in earlier SDKs!

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:42: return [key
stringByAddingPercentEncodingWithAllowedCharacters:
Does this %-encode a literal % too?

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:50: // been deprecated with iOS 9.0 / OS X
10.11 SDKs, this function re-implement
re-implements

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:53: static NSData
*SendSynchronousRequest(NSURLRequest *req,
Something like SendSynchronousNSURLRequest()?

Giving the type names is a little helpful.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:56: #if
(defined(__IPHONE_OS_VERSION_MIN_REQUIRED) &&  \
Same here.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:73: dispatch_semaphore_wait(wait_semaphone,
DISPATCH_TIME_FOREVER);
Looks like it’s leaked, there’s no dispatch_release().

[sdefresne, 2016-01-07 17:45:49]

Please take another look.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
File src/common/mac/HTTPMultipartUpload.m (right):

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:34: // deprecated with iOS 9.0 / OS X 10.11
SDKs, this function re-implement it
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> re-implements

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:37: static NSString
*EscapeStringByAddingPercent(NSString *key) {
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> Naming like PercentEncodeNSString()?

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:38: #if
(defined(__IPHONE_OS_VERSION_MIN_REQUIRED) &&  \
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> #include <Availability.h> for this.

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:40: (defined(MAC_OS_X_VERSION_MIN_REQUIRED)
&&     \
On 2016/01/07 at 17:19:16, Mark Mentovai wrote:
> #include <AvailabilityMacros.h> for this.

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:41: MAC_OS_X_VERSION_MIN_REQUIRED >= 1011)
On 2016/01/07 at 17:19:16, Mark Mentovai wrote:
> MAC_OS_X_VERSION_10_11 instead of 1011. Because 1011 is wrong, the actual
value is 101100. But you need to check that MAC_OS_X_VERSION_10_11 is actually
defined, because it isn’t defined in earlier SDKs!

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:42: return [key
stringByAddingPercentEncodingWithAllowedCharacters:
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> Does this %-encode a literal % too?

Yes according to my little testing in a swift playground:

var str = "Hello%, playground"
str.stringByAddingPercentEncodingWithAllowedCharacters(NSCharacterSet.alphanumericCharacterSet());

This prints the following:
"Hello%25%2C%20playground"

For the record, the deprecated function would print this:
"Hello%25,%20playground"

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:50: // been deprecated with iOS 9.0 / OS X
10.11 SDKs, this function re-implement
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> re-implements

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:53: static NSData
*SendSynchronousRequest(NSURLRequest *req,
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> Something like SendSynchronousNSURLRequest()?
> 
> Giving the type names is a little helpful.

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:56: #if
(defined(__IPHONE_OS_VERSION_MIN_REQUIRED) &&  \
On 2016/01/07 at 17:19:16, Mark Mentovai wrote:
> Same here.

Done.

https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipar...
src/common/mac/HTTPMultipartUpload.m:73: dispatch_semaphore_wait(wait_semaphone,
DISPATCH_TIME_FOREVER);
On 2016/01/07 at 17:19:15, Mark Mentovai wrote:
> Looks like it’s leaked, there’s no dispatch_release().

Thanks, fixed.

[Mark Mentovai, 2016-01-07 18:22:03]

LGTM

[sdefresne, 2016-01-07 18:48:27]

Description was changed from

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
==========

to

==========
Fix deprecatation warning when building for recent SDKs on iOS/OS X.

Fixes the following compilation warning when using recent version of
the iOS or OS X SDK by using the recommended new API:

../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error:
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in
iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead,
which always uses the recommended UTF-8 encoding, and which encodes for a
specific URL component or subcomponent since each URL component or subcomponent
has different rules for what characters are valid.
[-Werror,-Wdeprecated-declarations]
    [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         ^
CFURLCreateStringByAddingPercentEscapes

../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error:
'sendSynchronousRequest:returningResponse:error:' is deprecated: first
deprecated in iOS 9.0 - Use [NSURLSession
dataTaskWithRequest:completionHandler:] (see NSURLSession.h
[-Werror,-Wdeprecated-declarations]
    data = [NSURLConnection sendSynchronousRequest:req
                            ^

../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error:
'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 -
Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations]
    (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
     ^

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/7cc0d8562bf8b20b88cc941...
==========

[sdefresne, 2016-01-07 18:48:29]

Committed patchset #3 (id:40001) manually as
7cc0d8562bf8b20b88cc941ba72593cb7230ecf6 (presubmit successful).

[Olivier, 2016-01-21 09:12:30]

olivierrobin@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Olivier, 2016-01-21 09:12:31]

https://codereview.chromium.org/1563223004/diff/40001/src/common/mac/HTTPMult...
File src/common/mac/HTTPMultipartUpload.m (right):

https://codereview.chromium.org/1563223004/diff/40001/src/common/mac/HTTPMult...
src/common/mac/HTTPMultipartUpload.m:47: [NSCharacterSet
alphanumericCharacterSet]];
This should be URLQueryAllowedCharacterSet

Using alphanumericCharacterSet cause minidump processing failure on crash
server.

https://codereview.chromium.org/1563223004/diff/40001/src/common/mac/HTTPMult...
src/common/mac/HTTPMultipartUpload.m:76: result = data;
This variable is not retained and will be released when block ends causing a
crash on next access.

[Mark Mentovai, 2016-01-21 15:08:41]

Note the revert at https://codereview.chromium.org/1619603002/