add SkShader::newWithColorFilter

add SkShader::newWithColorFilter

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556693003

Committed: https://skia.googlesource.com/skia/+/3061af4a5f2b8ef00fc4a34b04cf99dfb780f1a1

[reed1, 2016-01-06 22:30:26]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2016-01-06 22:30:26]

will tweak the gm next

[reed1, 2016-01-06 22:30:41]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-06 22:30:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562193002/20001

[commit-bot: I haz the power, 2016-01-06 22:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 22:40:35]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-01-07 16:46:38]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-07 16:46:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562193002/40001

[commit-bot: I haz the power, 2016-01-07 16:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 16:47:23]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)

[reed1, 2016-01-07 17:09:03]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-07 17:09:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562193002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562193002/80001

[reed1, 2016-01-07 17:10:29]

PTAL -- ready to land?

[robertphillips, 2016-01-07 17:23:34]

lgtm + nits

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
File src/core/SkColorFilterShader.cpp (right):

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
src/core/SkColorFilterShader.cpp:71: : INHERITED(filterShader, rec)
put '}' on next line ? It was a bit jarring when reading through the code

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
src/core/SkColorFilterShader.cpp:89: const GrFragmentProcessor*
SkColorFilterShader::asFragmentProcessor(GrContext* context,
Can these be lined up with the 'GrContext' ?

[commit-bot: I haz the power, 2016-01-07 17:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 17:25:51]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-01-07 18:05:46]

lgtm

[reed1, 2016-01-07 19:30:52]

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
File src/core/SkColorFilterShader.cpp (right):

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
src/core/SkColorFilterShader.cpp:71: : INHERITED(filterShader, rec)
On 2016/01/07 17:23:33, robertphillips wrote:
> put '}' on next line ? It was a bit jarring when reading through the code

Done.

https://codereview.chromium.org/1562193002/diff/80001/src/core/SkColorFilterS...
src/core/SkColorFilterShader.cpp:89: const GrFragmentProcessor*
SkColorFilterShader::asFragmentProcessor(GrContext* context,
On 2016/01/07 17:23:34, robertphillips wrote:
> Can these be lined up with the 'GrContext' ?

Done.

[reed1, 2016-01-07 19:30:56]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-07 19:30:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1562193002/#ps100001
(title: "tweak formatting")

[commit-bot: I haz the power, 2016-01-07 19:32:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562193002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562193002/100001

[reed1, 2016-01-07 19:36:05]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-01-07 23:46:36]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-01-07 23:46:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562193002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562193002/100001

[commit-bot: I haz the power, 2016-01-07 23:47:33]

Description was changed from

==========
add SkShader::newWithColorFilter

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
add SkShader::newWithColorFilter

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3061af4a5f2b8ef00fc4a34b04cf99dfb780f1a1
==========

[commit-bot: I haz the power, 2016-01-07 23:47:33]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/3061af4a5f2b8ef00fc4a34b04cf99dfb780f1a1