Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1561983002: Fix dependency errors in Android Studio (Closed)

Created:
4 years, 11 months ago by Ian Wen
Modified:
4 years, 11 months ago
Reviewers:
Yusuf
Base URL:
https://github.com/GoogleChrome/custom-tabs-client.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix dependency errors in Android Studio MinSDK in customtabs target was set to 15, but other parts of the apps are not updated. This CL fixes it. Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/592e63122055d37e58cd37bd89a973eed98340ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M customtabs/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M customtabs/build.gradle View 1 chunk +2 lines, -1 line 0 comments Download
M shared/build.gradle View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
Ian Wen
Application/build.gradle was set to 15 in https://codereview.chromium.org/1559043005. This CL updates the rest gradle files.
4 years, 11 months ago (2016-01-06 04:33:46 UTC) #2
Yusuf
lgtm
4 years, 11 months ago (2016-01-06 18:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561983002/1
4 years, 11 months ago (2016-01-06 18:54:43 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 18:55:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/GoogleChrome/custom-tabs-client/commit/592e63122055d37e58c...

Powered by Google App Engine
This is Rietveld 408576698