Add APIs to CustomTabsIntent and CustomTabsSession for Bottombar

Add APIs to CustomTabsIntent and CustomTabsSession for Bottombar

Added APIs:
CustomTabsIntent#KEY_ID
CustomTabsIntent#TOOLBAR_ACTION_BUTTON_ID
CustomTabsIntent.Builder#addActionButton
CustomTabsSession#setActionButton

Old usage of CustomTabsIntent.Builder#addActionButton() should not be
affected.

Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/2aedcb406d8f6caf2db735374a56a6cab7c6871d

[Ian Wen, 2016-01-06 05:08:08]

ianwen@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2016-01-06 06:55:23]

https://codereview.chromium.org/1568433003/diff/1/customtabs/src/android/supp...
File customtabs/src/android/support/customtabs/CustomTabsIntent.java (right):

https://codereview.chromium.org/1568433003/diff/1/customtabs/src/android/supp...
customtabs/src/android/support/customtabs/CustomTabsIntent.java:302: * the
toolbar; if the bitmap is too wide, Chrome will push it to the bottom bar
instead. If
There is no Chrome specific code in Custom Tabs

https://codereview.chromium.org/1568433003/diff/1/customtabs/src/android/supp...
customtabs/src/android/support/customtabs/CustomTabsIntent.java:314:
bundle.putInt(KEY_ID, id);
maybe we should have the KEY verified here?

[Ian Wen, 2016-01-06 11:50:41]

I removed the UI code and made this CL only about API changes in support
library.

https://chromiumcodereview.appspot.com/1568433003/diff/1/customtabs/src/andro...
File customtabs/src/android/support/customtabs/CustomTabsIntent.java (right):

https://chromiumcodereview.appspot.com/1568433003/diff/1/customtabs/src/andro...
customtabs/src/android/support/customtabs/CustomTabsIntent.java:302: * the
toolbar; if the bitmap is too wide, Chrome will push it to the bottom bar
instead. If
On 2016/01/06 06:55:23, Yusuf wrote:
> There is no Chrome specific code in Custom Tabs

Ah my fault. Done.

https://chromiumcodereview.appspot.com/1568433003/diff/1/customtabs/src/andro...
customtabs/src/android/support/customtabs/CustomTabsIntent.java:314:
bundle.putInt(KEY_ID, id);
On 2016/01/06 06:55:23, Yusuf wrote:
> maybe we should have the KEY verified here?

If we don't throw exceptions but just print log warnings when, it is pretty much
the same as logging them inside chrome. Also maybe we want to make these helpers
a bit generic so that other browsers can verify the parameters a bit
differently?

[Yusuf, 2016-01-06 22:38:52]

lgtm

[Ian Wen, 2016-01-07 05:33:39]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-01-07 05:33:39]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1568433003/#ps40001
(title: "Make setActionButton not override addActionButton")

[commit-bot: I haz the power, 2016-01-07 05:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568433003/40001

[commit-bot: I haz the power, 2016-01-07 05:34:10]

Description was changed from

==========
Add APIs to CustomTabsIntent and CustomTabsSession for Bottombar

Added APIs:
CustomTabsIntent#KEY_ID
CustomTabsIntent#TOOLBAR_ACTION_BUTTON_ID
CustomTabsIntent.Builder#addActionButton
CustomTabsSession#setActionButton

Old usage of CustomTabsIntent.Builder#addActionButton() should not be
affected.
==========

to

==========
Add APIs to CustomTabsIntent and CustomTabsSession for Bottombar

Added APIs:
CustomTabsIntent#KEY_ID
CustomTabsIntent#TOOLBAR_ACTION_BUTTON_ID
CustomTabsIntent.Builder#addActionButton
CustomTabsSession#setActionButton

Old usage of CustomTabsIntent.Builder#addActionButton() should not be
affected.

Committed:
https://github.com/GoogleChrome/custom-tabs-client/commit/2aedcb406d8f6caf2db...
==========

[commit-bot: I haz the power, 2016-01-07 05:34:10]

Committed patchset #3 (id:40001) as
https://github.com/GoogleChrome/custom-tabs-client/commit/2aedcb406d8f6caf2db...