Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1559043005: Update support lib to last released state (Closed)

Created:
4 years, 11 months ago by Yusuf
Modified:
4 years, 11 months ago
Reviewers:
pasko, Benoit L
Base URL:
https://chromium.googlesource.com/external/github.com/GoogleChrome/custom-tabs-client.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update support lib to last released state Updates APIs to 23.1.1 and related changes. Short list of CLs 1b7158b CustomTabs: Use ActivityCompat and ActivityOptionsCompat 08043c5 Fix typo in CustomTabsSession#setActionButton javadoc f2fe067 [Custom Tabs] Add updateVisuals() in CustomTabsService 7f2ba521: Merge "Add a way of generating a CustomTabsSessionToken from an intent" into mnc-dev Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/3ecc03a19449c7ffd595fe2d08dea22e9d753ec8

Patch Set 1 #

Patch Set 2 : Added aidl changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -53 lines) Patch
M Application/build.gradle View 1 chunk +1 line, -1 line 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsIntent.java View 7 chunks +12 lines, -44 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsService.java View 3 chunks +18 lines, -1 line 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSession.java View 3 chunks +24 lines, -1 line 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSessionToken.java View 2 chunks +16 lines, -1 line 0 comments Download
M customtabs/src/android/support/customtabs/ICustomTabsService.aidl View 1 1 chunk +1 line, -0 lines 0 comments Download
M demos/build.gradle View 1 chunk +3 lines, -3 lines 0 comments Download
M shared/build.gradle View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yusuf
4 years, 11 months ago (2016-01-04 22:48:15 UTC) #2
pasko
lgtm One suggestion: for historical investigations it would be good to describe the range of ...
4 years, 11 months ago (2016-01-05 09:26:48 UTC) #3
Benoit L
On 2016/01/05 09:26:48, pasko wrote: > lgtm > > One suggestion: for historical investigations it ...
4 years, 11 months ago (2016-01-05 10:28:14 UTC) #4
Yusuf
On 2016/01/05 10:28:14, Benoit L wrote: > On 2016/01/05 09:26:48, pasko wrote: > > lgtm ...
4 years, 11 months ago (2016-01-05 18:19:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559043005/20001
4 years, 11 months ago (2016-01-05 18:19:27 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:20:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/GoogleChrome/custom-tabs-client/commit/3ecc03a19449c7ffd59...

Powered by Google App Engine
This is Rietveld 408576698