Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1561533003: AXMenuListOption should respect role attribute. (Closed)

Created:
4 years, 11 months ago by je_julie(Not used)
Modified:
4 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch makes AXMenuListOption respect role attribute. Because AXMenuListOption is a type of AXMockObject, it can't have determineAccessibilityRole() from AXNodeObject and role attribute is checked at roleValue(). BUG=467434 Committed: https://crrev.com/b592cbe206c36811da9c6f9af13f2c896ac30384 Cr-Commit-Position: refs/heads/master@{#370336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/role-attribute.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/role-attribute-expected.txt View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
je_julie(Not used)
Hi Dominic, Happy New Year! Normally we decide role with determineAccessibilityRole() but AXMenuListOption is a ...
4 years, 11 months ago (2016-01-05 14:10:15 UTC) #3
je_julie(Not used)
On 2016/01/05 14:10:15, je_julie wrote: > Hi Dominic, > Happy New Year! > > Normally ...
4 years, 11 months ago (2016-01-20 01:24:42 UTC) #4
dmazzoni
lgtm Hi! Sorry I missed this earlier, looks good!
4 years, 11 months ago (2016-01-20 06:03:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561533003/1
4 years, 11 months ago (2016-01-20 07:12:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 08:43:35 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:45:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b592cbe206c36811da9c6f9af13f2c896ac30384
Cr-Commit-Position: refs/heads/master@{#370336}

Powered by Google App Engine
This is Rietveld 408576698