Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

Issue 1561533003: AXMenuListOption should respect role attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 40
41 private: 41 private:
42 AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&); 42 AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&);
43 DECLARE_VIRTUAL_TRACE(); 43 DECLARE_VIRTUAL_TRACE();
44 44
45 bool isMenuListOption() const override { return true; } 45 bool isMenuListOption() const override { return true; }
46 46
47 Node* node() const override { return m_element; } 47 Node* node() const override { return m_element; }
48 void detach() override; 48 void detach() override;
49 bool isDetached() const override { return !m_element; } 49 bool isDetached() const override { return !m_element; }
50 AccessibilityRole roleValue() const override { return MenuListOptionRole; } 50 AccessibilityRole roleValue() const override;
51 bool canHaveChildren() const override { return false; } 51 bool canHaveChildren() const override { return false; }
52 52
53 Element* actionElement() const override; 53 Element* actionElement() const override;
54 bool isEnabled() const override; 54 bool isEnabled() const override;
55 bool isVisible() const override; 55 bool isVisible() const override;
56 bool isOffScreen() const override; 56 bool isOffScreen() const override;
57 bool isSelected() const override; 57 bool isSelected() const override;
58 void setSelected(bool) override; 58 void setSelected(bool) override;
59 bool canSetSelectedAttribute() const override; 59 bool canSetSelectedAttribute() const override;
60 LayoutRect elementRect() const override; 60 LayoutRect elementRect() const override;
61 String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObj ectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const overri de; 61 String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObj ectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const overri de;
62 bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override ; 62 bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override ;
63 63
64 RawPtrWillBeMember<HTMLOptionElement> m_element; 64 RawPtrWillBeMember<HTMLOptionElement> m_element;
65 }; 65 };
66 66
67 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, isMenuListOption()); 67 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, isMenuListOption());
68 68
69 } // namespace blink 69 } // namespace blink
70 70
71 #endif // AXMenuListOption_h 71 #endif // AXMenuListOption_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698