third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h - Issue 1561533003: AXMenuListOption should respect role attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

Issue 1561533003: AXMenuListOption should respect role attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

index 52f585eeae0c2d3c9cf06cee69b3e5c9ced192d1..2ca40f3c14fd6d79ac7d80e75cfe97c69475fb9f 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

@@ -47,7 +47,7 @@ private:

Node* node() const override { return m_element; }

void detach() override;

bool isDetached() const override { return !m_element; }

- AccessibilityRole roleValue() const override { return MenuListOptionRole; }

+ AccessibilityRole roleValue() const override;

bool canHaveChildren() const override { return false; }

Element* actionElement() const override;