Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: extensions/common/extension.cc

Issue 156153005: [Hotword, Extensions] Removing EXTERNAL_COMPONENT from IsPolicyLocation, adding a function to check… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: responding to comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension.cc
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index a0a545d9f3014e1e4fc96ff01903392444ff5e61..64f5c10f50d2f52fc49e7384a65b234176b69105 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -370,8 +370,7 @@ bool Extension::ShouldDisplayInExtensionSettings() const {
bool Extension::ShouldNotBeVisible() const {
// Don't show component extensions because they are only extensions as an
// implementation detail of Chrome.
- if ((location() == Manifest::COMPONENT ||
- location() == Manifest::EXTERNAL_COMPONENT) &&
+ if (extensions::Manifest::IsComponentLocation(location()) &&
!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kShowComponentExtensionOptions)) {
return true;

Powered by Google App Engine
This is Rietveld 408576698