Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: extensions/common/manifest.h

Issue 156153005: [Hotword, Extensions] Removing EXTERNAL_COMPONENT from IsPolicyLocation, adding a function to check… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: responding to comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest.h
diff --git a/extensions/common/manifest.h b/extensions/common/manifest.h
index 8f4c3c700ee9d0116dc55e8ada16c27d3b6b82af..a50e724c5792814e0c4c99962da0e031d1d04638 100644
--- a/extensions/common/manifest.h
+++ b/extensions/common/manifest.h
@@ -96,8 +96,13 @@ class Manifest {
// policy.
static inline bool IsPolicyLocation(Location location) {
return location == EXTERNAL_POLICY ||
- location == EXTERNAL_POLICY_DOWNLOAD ||
- location == EXTERNAL_COMPONENT;
+ location == EXTERNAL_POLICY_DOWNLOAD;
+ }
+
+ // Whether the |location| is an extension intended to be an internal part of
+ // Chrome.
+ static inline bool IsComponentLocation(Location location) {
+ return location == COMPONENT || location == EXTERNAL_COMPONENT;
}
// Unpacked extensions start off with file access since they are a developer
« chrome/browser/extensions/extension_service.cc ('K') | « extensions/common/extension.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698