[Hotword, Extensions] Removing EXTERNAL_COMPONENT from IsPolicyLocation, adding a function to check…

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 7724a3582201aa99545620a67e928eaf46dd56c3..c682016fd7404cb3d2a26b13ff39935636e4252e 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2182,7 +2182,8 @@ void ExtensionService::OnExtensionInstalled(
 
   // Certain extension locations are specific enough that we can
   // auto-acknowledge any extension that came from one of them.
-  if (Manifest::IsPolicyLocation(extension->location()))
+  if (Manifest::IsPolicyLocation(extension->location()) ||
+      extension->location() == Manifest::EXTERNAL_COMPONENT)

[Andrew T Wilson (Slow), 2014/02/11 15:56:32]

Just making sure that it's intentional that you aren't using
IsComponentLocation() here...

[rpetterson, 2014/02/11 18:34:18]

Yes this is intentional. I'm keeping the same behavior that was previously
there. Previously IsPolicyLocation included external components but not regular
components which IsComponentLocation includes. The response to this case is to
AcknowledgeExternalExtensions and my understanding is that regular component
extensions aren't considered external.

     AcknowledgeExternalExtension(extension->id());
   const Extension::State initial_state =
       initial_enable ? Extension::ENABLED : Extension::DISABLED;