Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1560693002: Avoid unnecessary invalidation scheduling. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Ruud van Asseldonk
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary invalidation scheduling. This is a reland of https://codereview.chromium.org/1514733002 without the removal of an assumed-to-be SubtreeStyleChange for attribute changes when you have a null style resolver, which turned out to cause asserts. We skip scheduling invalidation sets for an element when: * StyleResolver is null * Element is not inActiveDocument() * Element does not have a parent * Element parent has SubtreeStyleChange or ReattachStyleChange Additionally we skip descendant invalidations when: * Element has SubtreeStyleChange or ReattachStyleChange and sibling invalidations when: * Element.nextSibling is null R=ruuda@google.com BUG=557440 Committed: https://crrev.com/4762e2dc9c5ef4f8059ff499aa2600b1abfef7a7 Cr-Commit-Position: refs/heads/master@{#367617}

Patch Set 1 #

Patch Set 2 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -29 lines) Patch
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 6 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 5 chunks +25 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
rune
4 years, 11 months ago (2016-01-05 14:37:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560693002/1
4 years, 11 months ago (2016-01-05 14:38:04 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/75408) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-05 14:50:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560693002/20001
4 years, 11 months ago (2016-01-05 15:02:27 UTC) #7
Ruud van Asseldonk
I verified that https://crbug.com/570573 does not occur with this CL. Non-owner LGTM.
4 years, 11 months ago (2016-01-05 15:44:54 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 18:21:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560693002/20001
4 years, 11 months ago (2016-01-05 19:38:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 19:47:11 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 19:47:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4762e2dc9c5ef4f8059ff499aa2600b1abfef7a7
Cr-Commit-Position: refs/heads/master@{#367617}

Powered by Google App Engine
This is Rietveld 408576698