Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1569483002: [FastMalloc]: Annotate CSSSelector for heap profiling (Closed)

Created:
4 years, 11 months ago by Ruud van Asseldonk
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[FastMalloc]: Annotate CSSSelector for heap profiling In https://crrev.com/1474213002, annotations for top consumers of renderer memory were added to allow profiling type names in official builds. |CSSSelector| was among them, but the selectors allocated by |CSSSelectorList| were missed. BUG=524631 Committed: https://crrev.com/370537a527c75aa530ec812611941969bc71ac73 Cr-Commit-Position: refs/heads/master@{#367816}

Patch Set 1 #

Patch Set 2 : Go away dependent patchset #

Patch Set 3 : Line wrap comment at 80 columns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 2 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ruud van Asseldonk
Please take a look at this small change in |blink::CSSSelectorList|.
4 years, 11 months ago (2016-01-06 11:04:32 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-06 11:49:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569483002/40001
4 years, 11 months ago (2016-01-06 12:16:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-06 12:50:08 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 12:51:03 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/370537a527c75aa530ec812611941969bc71ac73
Cr-Commit-Position: refs/heads/master@{#367816}

Powered by Google App Engine
This is Rietveld 408576698