Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

Issue 1560693002: Avoid unnecessary invalidation scheduling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
index c5ac9ea098c3af67161eeb86b1aa5df1ac5c13a1..962a8ae9cd6b96c465481addd67e98256f9fa8a3 100644
--- a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
+++ b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
@@ -60,15 +60,18 @@ void StyleInvalidator::scheduleInvalidationSetsForElement(const InvalidationList
requiresDescendantInvalidation = true;
}
- if (invalidationLists.siblings.isEmpty() && !requiresDescendantInvalidation)
+ if (!requiresDescendantInvalidation && (invalidationLists.siblings.isEmpty() || !element.nextSibling()))
return;
element.setNeedsStyleInvalidation();
+
PendingInvalidations& pendingInvalidations = ensurePendingInvalidations(element);
- for (auto& invalidationSet : invalidationLists.siblings) {
- if (pendingInvalidations.siblings().contains(invalidationSet))
- continue;
- pendingInvalidations.siblings().append(invalidationSet);
+ if (element.nextSibling()) {
+ for (auto& invalidationSet : invalidationLists.siblings) {
+ if (pendingInvalidations.siblings().contains(invalidationSet))
+ continue;
+ pendingInvalidations.siblings().append(invalidationSet);
+ }
}
if (!requiresDescendantInvalidation)
« no previous file with comments | « third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698