Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1559903003: Remove strong mode support from rest argument creation. (Closed)

Created:
4 years, 11 months ago by mvstanton
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from rest argument creation. The mode requires an extra register, and since we aren't supporting it now, we can dispense with it. BUG= Committed: https://crrev.com/a94d6d6ede70fc42eed382ec8742af9734a37406 Cr-Commit-Position: refs/heads/master@{#33108}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Patch Set 4 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -64 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 3 chunks +1 line, -5 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interface-descriptors.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mvstanton
Hi Benedikt, Here is the CL which removes strong mode support from rest args. I ...
4 years, 11 months ago (2016-01-04 15:45:00 UTC) #2
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-05 05:02:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559903003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559903003/60001
4 years, 11 months ago (2016-01-05 10:20:40 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-05 10:51:05 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 10:51:49 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a94d6d6ede70fc42eed382ec8742af9734a37406
Cr-Commit-Position: refs/heads/master@{#33108}

Powered by Google App Engine
This is Rietveld 408576698