Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1559903003: Remove strong mode support from rest argument creation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: nit. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 7dbb1814cb94dc03de7a65831cc2d0dbbdac331f..02cf180a0cb57a352338448bfe6c87769fa733df 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -1515,10 +1515,7 @@ Reduction JSTypedLowering::ReduceJSCreateArguments(Node* node) {
// Use the ArgumentsAccessStub for materializing both mapped and unmapped
// arguments object, but only for non-inlined (i.e. outermost) frames.
if (outer_state->opcode() != IrOpcode::kFrameState) {
- Handle<SharedFunctionInfo> shared;
Isolate* isolate = jsgraph()->isolate();
- if (!state_info.shared_info().ToHandle(&shared)) return NoChange();
-
int parameter_count = state_info.parameter_count() - 1;
int parameter_offset = parameter_count * kPointerSize;
int offset = StandardFrameConstants::kCallerSPOffset + parameter_offset;
@@ -1527,6 +1524,8 @@ Reduction JSTypedLowering::ReduceJSCreateArguments(Node* node) {
jsgraph()->IntPtrConstant(offset));
if (p.type() != CreateArgumentsParameters::kRestArray) {
+ Handle<SharedFunctionInfo> shared;
+ if (!state_info.shared_info().ToHandle(&shared)) return NoChange();
bool unmapped = p.type() == CreateArgumentsParameters::kUnmappedArguments;
Callable callable = CodeFactory::ArgumentsAccess(
isolate, unmapped, shared->has_duplicate_parameters());
@@ -1553,8 +1552,6 @@ Reduction JSTypedLowering::ReduceJSCreateArguments(Node* node) {
node->InsertInput(graph()->zone(), 2, parameter_pointer);
node->InsertInput(graph()->zone(), 3,
jsgraph()->Constant(p.start_index()));
- node->InsertInput(graph()->zone(), 4,
- jsgraph()->Constant(shared->language_mode()));
NodeProperties::ChangeOp(node, new_op);
return Changed(node);
}
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698