Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 1559903003: Remove strong mode support from rest argument creation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: nit. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 39c2e5ad093c01b550239fc06ef5c504281f8a4b..867153ba03569e5c47df5ae437355f93bfd663c3 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -1156,28 +1156,25 @@ void RestParamAccessStub::GenerateNew(MacroAssembler* masm) {
// ecx : number of parameters (tagged)
// edx : parameters pointer
// ebx : rest parameter index (tagged)
- // edi : language mode (tagged)
// esp[0] : return address
// Check if the calling frame is an arguments adaptor frame.
Label runtime;
- __ mov(eax, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
- __ mov(eax, Operand(eax, StandardFrameConstants::kContextOffset));
+ __ mov(edi, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
+ __ mov(eax, Operand(edi, StandardFrameConstants::kContextOffset));
__ cmp(eax, Immediate(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
__ j(not_equal, &runtime);
// Patch the arguments.length and the parameters pointer.
- __ mov(edx, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
- __ mov(ecx, Operand(edx, ArgumentsAdaptorFrameConstants::kLengthOffset));
+ __ mov(ecx, Operand(edi, ArgumentsAdaptorFrameConstants::kLengthOffset));
__ lea(edx,
- Operand(edx, ecx, times_2, StandardFrameConstants::kCallerSPOffset));
+ Operand(edi, ecx, times_2, StandardFrameConstants::kCallerSPOffset));
__ bind(&runtime);
__ pop(eax); // Save return address.
__ push(ecx); // Push number of parameters.
__ push(edx); // Push parameters pointer.
__ push(ebx); // Push rest parameter index.
- __ push(edi); // Push language mode.
__ push(eax); // Push return address.
__ TailCallRuntime(Runtime::kNewRestParam);
}
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698