Add GetFrameConsumer() in VideoRenderer.

Add GetFrameConsumer() in VideoRenderer.

Also moved FrameConsumer interface to remoting/protocol. This
will allow to implement video rendering in WebrtcConnectionToHost as
WebRTC stack is responsible for video decoding.

BUG=547158
Committed: https://crrev.com/480531b40d9a83e25d524c7a78a34bf25c1ad690
Cr-Commit-Position: refs/heads/master@{#367600}

[Sergey Ulanov, 2016-01-04 22:09:53]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-01-04 22:46:28]

lgtm

https://codereview.chromium.org/1559043004/diff/1/remoting/client/plugin/pepp...
File remoting/client/plugin/pepper_video_renderer_3d.cc (right):

https://codereview.chromium.org/1559043004/diff/1/remoting/client/plugin/pepp...
remoting/client/plugin/pepper_video_renderer_3d.cc:182: NOTREACHED();
Can you add a comment explaining why this NOTREACHED is safe?

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
File remoting/protocol/video_renderer.h (right):

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
remoting/protocol/video_renderer.h:17: // render the video frames to receive.
Depending on configuration
s/to receive/received/? (I think--otherwise I don't understand the comment).

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
remoting/protocol/video_renderer.h:17: // render the video frames to receive.
Depending on configuration
s/configuration/the SessionConfig/?

[Sergey Ulanov, 2016-01-05 17:51:49]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2016-01-05 18:32:51]

Patchset #2 (id:40001) has been deleted

[Sergey Ulanov, 2016-01-05 18:32:57]

https://codereview.chromium.org/1559043004/diff/1/remoting/client/plugin/pepp...
File remoting/client/plugin/pepper_video_renderer_3d.cc (right):

https://codereview.chromium.org/1559043004/diff/1/remoting/client/plugin/pepp...
remoting/client/plugin/pepper_video_renderer_3d.cc:182: NOTREACHED();
On 2016/01/04 22:46:28, Jamie wrote:
> Can you add a comment explaining why this NOTREACHED is safe?

Done.

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
File remoting/protocol/video_renderer.h (right):

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
remoting/protocol/video_renderer.h:17: // render the video frames to receive.
Depending on configuration
On 2016/01/04 22:46:28, Jamie wrote:
> s/configuration/the SessionConfig/?

Just removed "Depending on configuration". IceConnectionToHost always uses
VideoStub, while WebrtcConnectionToHost calls FrameConsumer

https://codereview.chromium.org/1559043004/diff/1/remoting/protocol/video_ren...
remoting/protocol/video_renderer.h:17: // render the video frames to receive.
Depending on configuration
On 2016/01/04 22:46:28, Jamie wrote:
> s/to receive/received/? (I think--otherwise I don't understand the comment).

Done.

[Sergey Ulanov, 2016-01-05 18:33:03]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-01-05 18:33:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1559043004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-05 18:35:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559043004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559043004/60001

[commit-bot: I haz the power, 2016-01-05 19:12:52]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-01-05 19:13:39]

Description was changed from

==========
Add GetFrameConsumer() in VideoRenderer.

Also moved FrameConsumer interface to remoting/protocol. This
will allow to implement video rendering in WebrtcConnectionToHost as
WebRTC stack is responsible for video decoding.

BUG=547158
==========

to

==========
Add GetFrameConsumer() in VideoRenderer.

Also moved FrameConsumer interface to remoting/protocol. This
will allow to implement video rendering in WebrtcConnectionToHost as
WebRTC stack is responsible for video decoding.

BUG=547158

Committed: https://crrev.com/480531b40d9a83e25d524c7a78a34bf25c1ad690
Cr-Commit-Position: refs/heads/master@{#367600}
==========

[commit-bot: I haz the power, 2016-01-05 19:13:40]

Patchset 2 (id:??) landed as
https://crrev.com/480531b40d9a83e25d524c7a78a34bf25c1ad690
Cr-Commit-Position: refs/heads/master@{#367600}