Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: remoting/client/plugin/pepper_video_renderer_3d.cc

Issue 1559043004: Add GetFrameConsumer() in VideoRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_video_renderer
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/client/plugin/pepper_video_renderer_3d.h" 5 #include "remoting/client/plugin/pepper_video_renderer_3d.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 kMinimumPictureCount, 171 kMinimumPictureCount,
172 callback_factory_.NewCallback(&PepperVideoRenderer3D::OnInitialized)); 172 callback_factory_.NewCallback(&PepperVideoRenderer3D::OnInitialized));
173 CHECK_EQ(result, PP_OK_COMPLETIONPENDING) 173 CHECK_EQ(result, PP_OK_COMPLETIONPENDING)
174 << "video_decoder_.Initialize() returned " << result; 174 << "video_decoder_.Initialize() returned " << result;
175 } 175 }
176 176
177 protocol::VideoStub* PepperVideoRenderer3D::GetVideoStub() { 177 protocol::VideoStub* PepperVideoRenderer3D::GetVideoStub() {
178 return this; 178 return this;
179 } 179 }
180 180
181 protocol::FrameConsumer* PepperVideoRenderer3D::GetFrameConsumer() {
182 NOTREACHED();
Jamie 2016/01/04 22:46:28 Can you add a comment explaining why this NOTREACH
Sergey Ulanov 2016/01/05 18:32:56 Done.
183 return nullptr;
184 }
185
181 void PepperVideoRenderer3D::ProcessVideoPacket(scoped_ptr<VideoPacket> packet, 186 void PepperVideoRenderer3D::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
182 const base::Closure& done) { 187 const base::Closure& done) {
183 base::ScopedClosureRunner done_runner(done); 188 base::ScopedClosureRunner done_runner(done);
184 189
185 perf_tracker_->RecordVideoPacketStats(*packet); 190 perf_tracker_->RecordVideoPacketStats(*packet);
186 191
187 // Don't need to do anything if the packet is empty. Host sends empty video 192 // Don't need to do anything if the packet is empty. Host sends empty video
188 // packets when the screen is not changing. 193 // packets when the screen is not changing.
189 if (!packet->data().size()) 194 if (!packet->data().size())
190 return; 195 return;
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 gles2_if_->AttachShader(graphics_.pp_resource(), shader_program_, shader); 522 gles2_if_->AttachShader(graphics_.pp_resource(), shader_program_, shader);
518 gles2_if_->DeleteShader(graphics_.pp_resource(), shader); 523 gles2_if_->DeleteShader(graphics_.pp_resource(), shader);
519 } 524 }
520 525
521 void PepperVideoRenderer3D::CheckGLError() { 526 void PepperVideoRenderer3D::CheckGLError() {
522 GLenum error = gles2_if_->GetError(graphics_.pp_resource()); 527 GLenum error = gles2_if_->GetError(graphics_.pp_resource());
523 CHECK_EQ(error, static_cast<GLenum>(GL_NO_ERROR)) << "GL error: " << error; 528 CHECK_EQ(error, static_cast<GLenum>(GL_NO_ERROR)) << "GL error: " << error;
524 } 529 }
525 530
526 } // namespace remoting 531 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698