Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1559023003: Move VideoRenderer to remoting/protocol (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VideoRenderer to remoting/protocol VideoRenderer interface is going to be used by ConnectionToHost, so it belongs to the protocol layer. BUG=547158 Committed: https://crrev.com/feaabdc961c08518ea40392db837c92b26226b70 Cr-Commit-Position: refs/heads/master@{#367588}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -56 lines) Patch
M remoting/client/chromoting_client.h View 4 chunks +3 lines, -3 lines 0 comments Download
M remoting/client/chromoting_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/software_video_renderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/client/video_renderer.h View 1 chunk +0 lines, -31 lines 0 comments Download
A + remoting/protocol/video_renderer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M remoting/test/protocol_perftest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/test/test_chromoting_client.h View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/test_video_renderer.h View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-04 21:28:00 UTC) #2
Jamie
lgtm
4 years, 11 months ago (2016-01-04 22:00:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559023003/1
4 years, 11 months ago (2016-01-04 22:05:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/97369) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-04 22:20:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559023003/20001
4 years, 11 months ago (2016-01-04 23:49:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/3674)
4 years, 11 months ago (2016-01-05 00:36:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559023003/20001
4 years, 11 months ago (2016-01-05 17:42:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559023003/40001
4 years, 11 months ago (2016-01-05 17:52:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-05 18:31:03 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:32:55 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/feaabdc961c08518ea40392db837c92b26226b70
Cr-Commit-Position: refs/heads/master@{#367588}

Powered by Google App Engine
This is Rietveld 408576698