Infobar UI cleanup on Mac. Adds the yellow background gradient and...

Infobar UI cleanup on Mac.  Adds the yellow background gradient and
centers all of the buttons.

Also adds the ok/cancel buttons to the xib file.  Infobars that do not
need the buttons can remove them from the view before displaying.

BUG=http://crbug.com/14462
BUG=http://crbug.com/17195
TEST=Infobars should have yellow background, look less ugly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21128

[John Grabowski, 2009-07-20 22:25:15]

LGTM assuming BackgroundGradientView is unmodified

http://codereview.chromium.org/155788/diff/10/12
File chrome/browser/cocoa/infobar_controller.h (right):

http://codereview.chromium.org/155788/diff/10/12#newcode36
Line 36: - (IBAction)dismiss:(id)sender;
Perhaps add a comment: 
// Default behavior  for closeButton_
?

http://codereview.chromium.org/155788/diff/10/13
File chrome/browser/cocoa/infobar_controller.mm (right):

http://codereview.chromium.org/155788/diff/10/13#newcode57
Line 57: // The default implementation does nothing.
Perhaps a reasonable default is to act like dismiss:?

http://codereview.chromium.org/155788/diff/10/15
File chrome/browser/cocoa/infobar_gradient_view.h (right):

http://codereview.chromium.org/155788/diff/10/15#newcode10
Line 10: // A custom view that draws a 'standard' background gradient.
'standard' background gradient for info bars.

http://codereview.chromium.org/155788/diff/10/15#newcode12
Line 12: @interface InfoBarGradientView : NSView {
rietveld gets a little confused on renames so it's hard to tell what's really
going on here.  To be clear, you're not renaming this file from
background_gradient_view.h, are you?  Once your CL lands, we'll still have
background_gradient_view.h, yes?

http://codereview.chromium.org/155788/diff/10/16
File chrome/browser/cocoa/infobar_gradient_view_unittest.mm (right):

http://codereview.chromium.org/155788/diff/10/16#newcode35
Line 35: TEST_F(InfoBarGradientViewTest, Display) {
Excellent

[rohitrao (ping after 24h), 2009-07-20 22:32:46]

http://codereview.chromium.org/155788/diff/10/12
File chrome/browser/cocoa/infobar_controller.h (right):

http://codereview.chromium.org/155788/diff/10/12#newcode36
Line 36: - (IBAction)dismiss:(id)sender;
On 2009/07/20 22:25:15, John Grabowski wrote:
> Perhaps add a comment: 

Added "Called when someone clicks on the close button," to be like the comment
above.

http://codereview.chromium.org/155788/diff/10/13
File chrome/browser/cocoa/infobar_controller.mm (right):

http://codereview.chromium.org/155788/diff/10/13#newcode57
Line 57: // The default implementation does nothing.
On 2009/07/20 22:25:15, John Grabowski wrote:
> Perhaps a reasonable default is to act like dismiss:?

Eh, neither choice is really correct.  These functions exist in the base class
only so I have something to connect to in the xib file.  I could throw in a
NOTREACHED(), if you'd like that better.

http://codereview.chromium.org/155788/diff/10/15
File chrome/browser/cocoa/infobar_gradient_view.h (right):

http://codereview.chromium.org/155788/diff/10/15#newcode10
Line 10: // A custom view that draws a 'standard' background gradient.
On 2009/07/20 22:25:15, John Grabowski wrote:
> 'standard' background gradient for info bars.
> 
> 

Done.

http://codereview.chromium.org/155788/diff/10/15#newcode12
Line 12: @interface InfoBarGradientView : NSView {
On 2009/07/20 22:25:15, John Grabowski wrote:
> Once your CL lands, we'll still have
> background_gradient_view.h, yes?

Yeah, I did an "svn cp."  This file was similar enough to BGV that I felt a copy
was warranted, but different enough that it didn't seem worth merging the two
classes.

http://codereview.chromium.org/155788/diff/10/16
File chrome/browser/cocoa/infobar_gradient_view_unittest.mm (right):

http://codereview.chromium.org/155788/diff/10/16#newcode35
Line 35: TEST_F(InfoBarGradientViewTest, Display) {
On 2009/07/20 22:25:15, John Grabowski wrote:
> Excellent

I aim to please.