Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: chrome/browser/cocoa/infobar_gradient_view_unittest.mm

Issue 155788: Infobar UI cleanup on Mac. Adds the yellow background gradient and... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/infobar_gradient_view.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/infobar_gradient_view_unittest.mm
===================================================================
--- chrome/browser/cocoa/infobar_gradient_view_unittest.mm (revision 21067)
+++ chrome/browser/cocoa/infobar_gradient_view_unittest.mm (working copy)
@@ -5,37 +5,41 @@
#import <Cocoa/Cocoa.h>
#include "base/scoped_nsobject.h"
-#import "chrome/browser/cocoa/background_gradient_view.h"
+#import "chrome/browser/cocoa/infobar_gradient_view.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
-class BackgroundGradientViewTest : public testing::Test {
+class InfoBarGradientViewTest : public testing::Test {
public:
- BackgroundGradientViewTest() {
+ InfoBarGradientViewTest() {
NSRect frame = NSMakeRect(0, 0, 100, 30);
- view_.reset([[BackgroundGradientView alloc] initWithFrame:frame]);
+ view_.reset([[InfoBarGradientView alloc] initWithFrame:frame]);
[cocoa_helper_.contentView() addSubview:view_.get()];
}
CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...
- scoped_nsobject<BackgroundGradientView> view_;
+ scoped_nsobject<InfoBarGradientView> view_;
};
// Test adding/removing from the view hierarchy, mostly to ensure nothing
// leaks or crashes.
-TEST_F(BackgroundGradientViewTest, AddRemove) {
+TEST_F(InfoBarGradientViewTest, AddRemove) {
EXPECT_EQ(cocoa_helper_.contentView(), [view_ superview]);
[view_.get() removeFromSuperview];
EXPECT_FALSE([view_ superview]);
}
// Test drawing, mostly to ensure nothing leaks or crashes.
-TEST_F(BackgroundGradientViewTest, Display) {
+TEST_F(InfoBarGradientViewTest, Display) {
[view_ display];
- [view_ setShowsDivider:YES];
- [view_ display];
}
+// Assert that the view is non-opaque, because otherwise we will end
+// up with findbar painting issues.
+TEST_F(InfoBarGradientViewTest, AssertViewNonOpaque) {
+ EXPECT_FALSE([view_ isOpaque]);
+}
+
} // namespace
« no previous file with comments | « chrome/browser/cocoa/infobar_gradient_view.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698