Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/cocoa/infobar_gradient_view_unittest.mm

Issue 155788: Infobar UI cleanup on Mac. Adds the yellow background gradient and... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/cocoa/infobar_gradient_view.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #import "chrome/browser/cocoa/background_gradient_view.h" 8 #import "chrome/browser/cocoa/infobar_gradient_view.h"
9 #import "chrome/browser/cocoa/cocoa_test_helper.h" 9 #import "chrome/browser/cocoa/cocoa_test_helper.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace { 12 namespace {
13 13
14 class BackgroundGradientViewTest : public testing::Test { 14 class InfoBarGradientViewTest : public testing::Test {
15 public: 15 public:
16 BackgroundGradientViewTest() { 16 InfoBarGradientViewTest() {
17 NSRect frame = NSMakeRect(0, 0, 100, 30); 17 NSRect frame = NSMakeRect(0, 0, 100, 30);
18 view_.reset([[BackgroundGradientView alloc] initWithFrame:frame]); 18 view_.reset([[InfoBarGradientView alloc] initWithFrame:frame]);
19 [cocoa_helper_.contentView() addSubview:view_.get()]; 19 [cocoa_helper_.contentView() addSubview:view_.get()];
20 } 20 }
21 21
22 CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc... 22 CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...
23 scoped_nsobject<BackgroundGradientView> view_; 23 scoped_nsobject<InfoBarGradientView> view_;
24 }; 24 };
25 25
26 // Test adding/removing from the view hierarchy, mostly to ensure nothing 26 // Test adding/removing from the view hierarchy, mostly to ensure nothing
27 // leaks or crashes. 27 // leaks or crashes.
28 TEST_F(BackgroundGradientViewTest, AddRemove) { 28 TEST_F(InfoBarGradientViewTest, AddRemove) {
29 EXPECT_EQ(cocoa_helper_.contentView(), [view_ superview]); 29 EXPECT_EQ(cocoa_helper_.contentView(), [view_ superview]);
30 [view_.get() removeFromSuperview]; 30 [view_.get() removeFromSuperview];
31 EXPECT_FALSE([view_ superview]); 31 EXPECT_FALSE([view_ superview]);
32 } 32 }
33 33
34 // Test drawing, mostly to ensure nothing leaks or crashes. 34 // Test drawing, mostly to ensure nothing leaks or crashes.
35 TEST_F(BackgroundGradientViewTest, Display) { 35 TEST_F(InfoBarGradientViewTest, Display) {
36 [view_ display];
37 [view_ setShowsDivider:YES];
38 [view_ display]; 36 [view_ display];
39 } 37 }
40 38
39 // Assert that the view is non-opaque, because otherwise we will end
40 // up with findbar painting issues.
41 TEST_F(InfoBarGradientViewTest, AssertViewNonOpaque) {
42 EXPECT_FALSE([view_ isOpaque]);
43 }
44
41 } // namespace 45 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/infobar_gradient_view.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698