Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1557433002: Revert of tcmalloc: Use C++11 atomics where appropriate. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
JF
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of tcmalloc: Use C++11 atomics where appropriate. (patchset #8 id:140001 of https://codereview.chromium.org/1549913002/ ) Reason for revert: Caused performance problems (see http://crbug.com/572525 and dupes) Original issue's description: > tcmalloc: Use C++11 atomics where appropriate. > > Ports these CLs to tcmalloc: > https://codereview.chromium.org/636783002/ > https://codereview.chromium.org/1466833002/ (except mac) > > No intended behavior change, but it should remove > the static initializer in atomicops_internals_x86_gcc.h > on Linux. It's also less code. > > BUG=94925, 559247 > > Committed: https://crrev.com/e13537fe418eff11d3cab9077f6a647d7c74f103 > Cr-Commit-Position: refs/heads/master@{#366904} TBR=jfb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=94925, 559247 Committed: https://crrev.com/36388503f7f90d6ce97f15d861a6774e6d9385ee Cr-Commit-Position: refs/heads/master@{#367069}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -235 lines) Patch
M base/allocator/BUILD.gn View 1 1 chunk +5 lines, -1 line 0 comments Download
M base/allocator/allocator.gyp View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/tcmalloc/README.chromium View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/base/atomicops.h View 1 2 chunks +21 lines, -1 line 0 comments Download
A + third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-v6plus.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/tcmalloc/chromium/src/base/atomicops-internals-linuxppc.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/tcmalloc/chromium/src/base/atomicops_internals_portable.h View 1 chunk +0 lines, -231 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
Created Revert of tcmalloc: Use C++11 atomics where appropriate.
4 years, 11 months ago (2015-12-29 14:26:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557433002/1
4 years, 11 months ago (2015-12-29 14:26:46 UTC) #2
commit-bot: I haz the power
Failed to apply patch for base/allocator/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 11 months ago (2015-12-29 14:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557433002/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557433002/230001
4 years, 11 months ago (2015-12-29 14:42:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 11 months ago (2015-12-29 14:42:32 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 14:43:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36388503f7f90d6ce97f15d861a6774e6d9385ee
Cr-Commit-Position: refs/heads/master@{#367069}

Powered by Google App Engine
This is Rietveld 408576698