third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h - Issue 1557433002: Revert of tcmalloc: Use C++11 atomics where appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h

Issue 1557433002: Revert of tcmalloc: Use C++11 atomics where appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/base/atomicops.h ('k') | third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-v6plus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h

diff --git a/third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-generic.h b/third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h

similarity index 99%

copy from third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-generic.h

copy to third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h

index 4acb76afd755246f934e89fdeeb35e0bb99209ba..e083f8d37308030f8dad15f73ea1f495c0600903 100644

--- a/third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-generic.h

+++ b/third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h

@@ -38,7 +38,7 @@

#define BASE_ATOMICOPS_INTERNALS_ARM_GENERIC_H_

#include <stdio.h>

-#include <stdlib.h>

+#include "base/abort.h"

#include "base/basictypes.h"

typedef int32_t Atomic32;

@@ -160,7 +160,7 @@ inline Atomic32 Release_Load(volatile const Atomic32* ptr) {

inline void NotImplementedFatalError(const char *function_name) {

fprintf(stderr, "64-bit %s() not implemented on this platform\n",

function_name);

- abort();

+ tcmalloc::Abort();

}

inline Atomic64 NoBarrier_CompareAndSwap(volatile Atomic64* ptr,