Delete reallyHasAlpha() from SkCodec

Delete reallyHasAlpha() from SkCodec

TBR=reed
BUG=skia:3582
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557403002

Committed: https://skia.googlesource.com/skia/+/a4970dc973459d2607ce80623452bf8470adf6f1

[msarett, 2016-01-05 16:15:30]

Description was changed from

==========
Delete reallyHasAlpha() from SkCodec

BUG=skia:3582
==========

to

==========
Delete reallyHasAlpha() from SkCodec

BUG=skia:3582
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-08 19:54:28]

msarett@google.com changed reviewers:
+ mtklein@google.com, scroggo@google.com

[msarett, 2016-01-08 19:54:29]

Let's go ahead with this.

[scroggo, 2016-01-08 20:08:45]

lgtm

LGTM

I do not envy you for making this repetitive change... Thanks!

https://codereview.chromium.org/1557403002/diff/1/src/codec/SkCodec_libpng.cpp
File src/codec/SkCodec_libpng.cpp (right):

https://codereview.chromium.org/1557403002/diff/1/src/codec/SkCodec_libpng.cp...
src/codec/SkCodec_libpng.cpp:167: *colorPtr++ = proc(*trans++, palette->red,
palette->green, palette->blue);
Can your other CL update this to use the SIMD versions of premultiply?

[msarett, 2016-01-08 20:10:29]

https://codereview.chromium.org/1557403002/diff/1/src/codec/SkCodec_libpng.cpp
File src/codec/SkCodec_libpng.cpp (right):

https://codereview.chromium.org/1557403002/diff/1/src/codec/SkCodec_libpng.cp...
src/codec/SkCodec_libpng.cpp:167: *colorPtr++ = proc(*trans++, palette->red,
palette->green, palette->blue);
On 2016/01/08 20:08:45, scroggo wrote:
> Can your other CL update this to use the SIMD versions of premultiply?

Yes!  Good point.

[msarett, 2016-01-08 20:10:49]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-01-08 20:10:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557403002/1

[commit-bot: I haz the power, 2016-01-08 20:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 20:11:58]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-01-08 20:35:26]

msarett@google.com changed reviewers:
+ reed@google.com

[msarett, 2016-01-08 20:35:26]

Adding reed@ to look over the API change.

[msarett, 2016-01-11 14:57:02]

Description was changed from

==========
Delete reallyHasAlpha() from SkCodec

BUG=skia:3582
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete reallyHasAlpha() from SkCodec

TBR=reed
BUG=skia:3582
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-11 14:57:09]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-01-11 14:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557403002/1

[commit-bot: I haz the power, 2016-01-11 14:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 14:57:55]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[msarett, 2016-01-11 15:04:00]

The CQ bit was checked by msarett@google.com

[msarett, 2016-01-11 15:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1557403002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-11 15:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557403002/20001

[commit-bot: I haz the power, 2016-01-11 15:23:28]

Description was changed from

==========
Delete reallyHasAlpha() from SkCodec

TBR=reed
BUG=skia:3582
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete reallyHasAlpha() from SkCodec

TBR=reed
BUG=skia:3582
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a4970dc973459d2607ce80623452bf8470adf6f1
==========

[commit-bot: I haz the power, 2016-01-11 15:23:29]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a4970dc973459d2607ce80623452bf8470adf6f1