Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: include/codec/SkCodec.h

Issue 1557403002: Delete reallyHasAlpha() from SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/codec/SkCodecPriv.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/codec/SkCodec.h
diff --git a/include/codec/SkCodec.h b/include/codec/SkCodec.h
index d06c2c3399e4858e30626945948f4933f5d059c6..597ebd039e8a806bc09cf4c6f7eb0d1b8746ded8 100644
--- a/include/codec/SkCodec.h
+++ b/include/codec/SkCodec.h
@@ -278,18 +278,6 @@ public:
Result getPixels(const SkImageInfo& info, void* pixels, size_t rowBytes);
/**
- * Some images may initially report that they have alpha due to the format
- * of the encoded data, but then never use any colors which have alpha
- * less than 100%. This function can be called *after* decoding to
- * determine if such an image truly had alpha. Calling it before decoding
- * is undefined.
- * FIXME: see skbug.com/3582.
- */
- bool reallyHasAlpha() const {
- return kOpaque_SkAlphaType != this->getInfo().alphaType() && this->onReallyHasAlpha();
- }
-
- /**
* The remaining functions revolve around decoding scanlines.
*/
@@ -487,16 +475,6 @@ protected:
}
/**
- * This is only called if the image indicates that it is not opaque.
- * By default we will assume that the image is in fact non-opaque.
- * Subclasses may override this function if they intend to verify
- * that the image actually has alpha.
- */
- virtual bool onReallyHasAlpha() const {
- return true;
- }
-
- /**
* If the stream was previously read, attempt to rewind.
*
* If the stream needed to be rewound, call onRewind.
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/codec/SkCodecPriv.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698