Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1556773002: Convert Pass()→std::move() in //chromeos (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, dkrahn+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //chromeos (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=stevenjb@chromium.org Committed: https://crrev.com/7df85ba2d56769fc627ed8e21f916705736df8e7 Cr-Commit-Position: refs/heads/master@{#367230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -140 lines) Patch
M chromeos/attestation/attestation_flow.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/attestation/attestation_flow_unittest.cc View 12 chunks +13 lines, -11 lines 0 comments Download
M chromeos/cert_loader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/cert_loader_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/cryptohome/homedir_methods_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/dbus/blocking_method_caller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 3 chunks +45 lines, -32 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/permission_broker_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/dbus/pipe_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/services/console_service_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/services/cros_dbus_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/services/cros_dbus_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/dbus/services/display_power_service_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chromeos/dbus/services/service_provider_test_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/geolocation/simple_geolocation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/firewall_hole.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_device_handler_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/network/network_handler_callbacks.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/network/network_ui_data.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chromeos/network/network_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_mapper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M chromeos/network/onc/onc_normalizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_test_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/onc/onc_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/policy_util.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chromeos/network/prohibited_technologies_handler_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/network/shill_property_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/timezone/timezone_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/timezone/timezone_request.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chromeos/timezone/timezone_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/tools/onc_validator/onc_validator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dcheng
4 years, 11 months ago (2015-12-31 00:44:30 UTC) #1
dcheng
(Oops fixed the issue description)
4 years, 11 months ago (2015-12-31 00:45:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556773002/1
4 years, 11 months ago (2015-12-31 00:45:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 01:16:22 UTC) #7
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 04:49:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556773002/1
4 years, 11 months ago (2015-12-31 04:50:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 04:56:46 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 04:58:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7df85ba2d56769fc627ed8e21f916705736df8e7
Cr-Commit-Position: refs/heads/master@{#367230}

Powered by Google App Engine
This is Rietveld 408576698