Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/attestation/attestation_flow_unittest.cc

Issue 1556773002: Convert Pass()→std::move() in //chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/attestation/attestation_flow.cc ('k') | chromeos/cert_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/attestation/attestation_flow_unittest.cc
diff --git a/chromeos/attestation/attestation_flow_unittest.cc b/chromeos/attestation/attestation_flow_unittest.cc
index 578393bf924097b9e66652723d982da1281511c7..99b98bd35d409f025c01c1ec2b618ab705a1e716 100644
--- a/chromeos/attestation/attestation_flow_unittest.cc
+++ b/chromeos/attestation/attestation_flow_unittest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <utility>
+
#include "base/bind.h"
#include "base/memory/scoped_ptr.h"
#include "base/run_loop.h"
@@ -139,7 +141,7 @@ TEST_F(AttestationFlowTest, GetCertificate) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "fake@test.com",
"fake_origin", true, mock_callback);
Run();
@@ -167,7 +169,7 @@ TEST_F(AttestationFlowTest, GetCertificate_NoEK) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -198,7 +200,7 @@ TEST_F(AttestationFlowTest, GetCertificate_EKRejected) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -234,7 +236,7 @@ TEST_F(AttestationFlowTest, GetCertificate_FailEnroll) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -278,7 +280,7 @@ TEST_F(AttestationFlowTest, GetMachineCertificateAlreadyEnrolled) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_MACHINE_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -307,7 +309,7 @@ TEST_F(AttestationFlowTest, GetCertificate_FailCreateCertRequest) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -339,7 +341,7 @@ TEST_F(AttestationFlowTest, GetCertificate_CertRequestRejected) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -364,7 +366,7 @@ TEST_F(AttestationFlowTest, GetCertificate_FailIsEnrolled) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
@@ -411,7 +413,7 @@ TEST_F(AttestationFlowTest, GetCertificate_CheckExisting) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", false,
mock_callback);
Run();
@@ -442,7 +444,7 @@ TEST_F(AttestationFlowTest, GetCertificate_AlreadyExists) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", false,
mock_callback);
Run();
@@ -477,7 +479,7 @@ TEST_F(AttestationFlowTest, AlternatePCA) {
base::Unretained(&observer));
scoped_ptr<ServerProxy> proxy_interface(proxy.release());
- AttestationFlow flow(&async_caller, &client, proxy_interface.Pass());
+ AttestationFlow flow(&async_caller, &client, std::move(proxy_interface));
flow.GetCertificate(PROFILE_ENTERPRISE_USER_CERTIFICATE, "", "", true,
mock_callback);
Run();
« no previous file with comments | « chromeos/attestation/attestation_flow.cc ('k') | chromeos/cert_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698