chromeos/network/network_state_unittest.cc - Issue 1556773002: Convert Pass()→std::move() in //chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state_unittest.cc

Issue 1556773002: Convert Pass()→std::move() in //chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_state_unittest.cc

diff --git a/chromeos/network/network_state_unittest.cc b/chromeos/network/network_state_unittest.cc

index 0d48cdcb025762f72ee3fbed6f31e102c0542e7a..25684ae70058d3fa15ce94dd80e792d919d1588a 100644

--- a/chromeos/network/network_state_unittest.cc

+++ b/chromeos/network/network_state_unittest.cc

@@ -5,6 +5,7 @@

#include "chromeos/network/network_state.h"

#include <stdint.h>

+#include <utility>

#include "base/i18n/streaming_utf8_validator.h"

#include "base/macros.h"

@@ -228,7 +229,7 @@ TEST_F(NetworkStateTest, VPNThirdPartyProvider) {

shill::kProviderThirdPartyVpn);

provider->SetStringWithoutPathExpansion(

shill::kHostProperty, "third-party-vpn-provider-extension-id");

- EXPECT_TRUE(SetProperty(shill::kProviderProperty, provider.Pass()));

+ EXPECT_TRUE(SetProperty(shill::kProviderProperty, std::move(provider)));

SignalInitialPropertiesReceived();

EXPECT_EQ(network_state_.vpn_provider_type(), shill::kProviderThirdPartyVpn);

EXPECT_EQ(network_state_.third_party_vpn_provider_extension_id(),

« no previous file with comments | « chromeos/network/network_state_handler.cc ('k') | chromeos/network/network_ui_data.cc » ('j') | no next file with comments »