take gr-context parameter to refEncoded, indicating a desire for only gpu-specific formats

take gr-context parameter to refEncoded, indicating a desire for only gpu-specific formats

Prime motivator:
- we always call refEncoded on the generator when trying to upload
   - we call it *before* we ask for raster or YUV
- for blink, this call can be very slow, as they have to cons-up their SkData the first time (and grab a mutex to do it)
- this parameter will indicate to them that we're only interested in gpu formats, which they will know if they have.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556333004

Committed: https://skia.googlesource.com/skia/+/05dd251e5e135626d170b9e77eb64729bd482169

[reed1, 2016-01-05 15:48:24]

Description was changed from

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats


add grcontext param

BUG=skia:
==========

to

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats


add grcontext param

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-05 15:50:30]

Description was changed from

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats


add grcontext param

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats

Prime motivator:
- we always call refEncoded on the generator when trying to upload
   - we call it *before* we ask for raster or YUV
- for blink, this call can be very slow, as they have to cons-up their SkData
the first time (and grab a mutex to do it)
- this parameter will indicate to them that we're only interested in gpu
formats, which they will know if they have.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-05 15:51:00]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com, scroggo@google.com

[reed1, 2016-01-05 15:51:01]

ptal -- both at the impl (pretty simple) and the API contract

[reed1, 2016-01-05 15:51:12]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 15:51:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556333004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556333004/1

[commit-bot: I haz the power, 2016-01-05 16:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 16:06:47]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-01-05 16:07:27]

Seems ok to me.

[reed1, 2016-01-05 16:11:02]

I could pass an enum instead, but I'm betting on the client possibly wanting to
actually access the context (now or in the future). If we think that is
overkill, I can go the enum route.

[robertphillips, 2016-01-05 16:25:49]

lgtm

https://codereview.chromium.org/1556333004/diff/1/include/core/SkImageGenerat...
File include/core/SkImageGenerator.h (right):

https://codereview.chromium.org/1556333004/diff/1/include/core/SkImageGenerat...
include/core/SkImageGenerator.h:73: *  of this data.
doc 'ctx' param ?

[reed1, 2016-01-05 17:00:15]

https://codereview.chromium.org/1556333004/diff/1/include/core/SkImageGenerat...
File include/core/SkImageGenerator.h (right):

https://codereview.chromium.org/1556333004/diff/1/include/core/SkImageGenerat...
include/core/SkImageGenerator.h:73: *  of this data.
On 2016/01/05 16:25:49, robertphillips wrote:
> doc 'ctx' param ?

Done.

[reed1, 2016-01-05 17:00:22]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-05 17:00:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1556333004/#ps20001
(title: "update dox")

[commit-bot: I haz the power, 2016-01-05 17:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556333004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556333004/20001

[commit-bot: I haz the power, 2016-01-05 17:16:21]

Description was changed from

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats

Prime motivator:
- we always call refEncoded on the generator when trying to upload
   - we call it *before* we ask for raster or YUV
- for blink, this call can be very slow, as they have to cons-up their SkData
the first time (and grab a mutex to do it)
- this parameter will indicate to them that we're only interested in gpu
formats, which they will know if they have.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
take gr-context parameter to refEncoded, indicating a desire for only
gpu-specific formats

Prime motivator:
- we always call refEncoded on the generator when trying to upload
   - we call it *before* we ask for raster or YUV
- for blink, this call can be very slow, as they have to cons-up their SkData
the first time (and grab a mutex to do it)
- this parameter will indicate to them that we're only interested in gpu
formats, which they will know if they have.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/05dd251e5e135626d170b9e77eb64729bd482169
==========

[commit-bot: I haz the power, 2016-01-05 17:16:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/05dd251e5e135626d170b9e77eb64729bd482169

[scroggo, 2016-01-05 18:02:16]

On 2016/01/05 16:11:02, reed1 wrote:
> I could pass an enum instead, but I'm betting on the client possibly wanting
to
> actually access the context (now or in the future). If we think that is
> overkill, I can go the enum route.

That is my only concern about this change. How might the caller use the context?

[reed1, 2016-01-05 18:14:57]

Today, as documented, they should only check for non-null.

[scroggo, 2016-01-05 19:02:22]

On 2016/01/05 18:14:57, reed1 wrote:
> Today, as documented, they should only check for non-null.

Should we defensively make the param const?

[reed1, 2016-01-05 20:27:45]

On 2016/01/05 19:02:22, scroggo wrote:
> On 2016/01/05 18:14:57, reed1 wrote:
> > Today, as documented, they should only check for non-null.
> 
> Should we defensively make the param const?

no idea

I'm sure we can change the parameter type (again) as needed :)